feat(common): remove jquery-ui-dist from deps, use jquery-ui only #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
Aug 3, 2022
•
ghiscoding
commented
- the dependency "jquery-ui-dist" was added for convenience (all-in-one build) but that package wasn't managed by the jQuery team and it is now behind in version number, it is missing a security patch and so this PR removes the use of that external "jquery-ui-dist", we should rely solely on the official package "jquery-ui" which is maintained by the official jQuery team
- the dependency "jquery-ui-dist" was added for convenience (all-in-one) but wasn't managed by the jQuery team and it is now behind in version, it is missing a security patch and so this PR removes the use of that external "jquery-ui-dist", we should rely only on the official package "jquery-ui" which is maintained by the jQuery team
- the dependency "jquery-ui-dist" was added for convenience (all-in-one) but wasn't managed by the jQuery team and it is now behind in version, it is missing a security patch and so this PR removes the use of that external "jquery-ui-dist", we should rely only on the official package "jquery-ui" which is maintained by the jQuery team
…coding/slickgrid-universal into chore/remove-jquery-ui-dist
ghiscoding
changed the title
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 233 233
Lines 16439 16439
Branches 5490 5490
=========================================
Hits 16439 16439 Help us with your feedback. Take ten seconds to tell us how you rate us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.