Delete From and Index trait impls for EndianSlice #669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The From implementation for &[u8] can cause type inference problems. We could change back to only having an Into implementation, but in practice EndianSlice is never used in a generic context that requires this trait, and the &[u8] is easily obtained by either the
slice
method or Deref.Remove the Index implementation while we're at it, since this is also not useful in practice.
See rust-lang/rust#113238