Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete From and Index trait impls for EndianSlice #669

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Delete From and Index trait impls for EndianSlice #669

merged 1 commit into from
Aug 7, 2023

Commits on Aug 6, 2023

  1. Delete From and Index trait impls for EndianSlice 

    The From implementation for &[u8] can cause type inference problems.
We could change back to only having an Into implementation, but in practice
EndianSlice is never used in a generic context that requires this trait,
and the &[u8] is easily obtained by either the `slice` method or Deref.

Remove the Index implementation while we're at it, since this is
also not useful in practice.
    @philipc
    philipc committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    22cb829 View commit details
    Browse the repository at this point in the history