Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Liquid under HTML #5150

Closed
4 tasks done
Nixinova opened this issue Jan 16, 2021 · 4 comments
Closed
4 tasks done

Group Liquid under HTML #5150

Nixinova opened this issue Jan 16, 2021 · 4 comments

Comments

@Nixinova
Copy link
Contributor

Preliminary Steps

Please confirm you have...

Description

Currently Linguist classifies Liquid as its own language. However, extremely similar languages like Nunjucks are classified under a subset of HTML (HTML+Django). Therefore Liquid should also be classified as a subset of HTML, as Liquid and Nunjucks are very, very similar in syntax and it makes no sense for them to be classified in two different ways.
@lildude
Copy link
Member

lildude commented Jan 22, 2021

Sounds reasonable to me. We'd welcome a PR adding the grouping.

@Alhadis
Copy link
Collaborator

Alhadis commented Jan 22, 2021

Hold up. This would contradict our changes in #4979, where similar templating languages were removed from the HTML group.

If there's a change to be made, it should be to dissociate Nunjucks from HTML+Django.

@lildude
Copy link
Member

lildude commented Jan 22, 2021

🤦 Good catch @Alhadis; I completely forgot about that.

@Nixinova
Copy link
Contributor Author

Nixinova commented Jan 22, 2021 •
edited
Loading

Ah, so it should go the other way, with Nunjucks being ungrouped from HTML instead? Will close this issue and issue a PR for that then.

@Nixinova Nixinova mentioned this issue Jan 23, 2021
Merged
lildude added a commit that referenced this issue Feb 10, 2021
@Nixinova @lildude @Alhadis
Split Nunjucks into its own language (#5167)
5b72c0e 
* Split Nunjucks into its own language

Keep the Django syntax highlight references
Color from official docs
Related to discussion at #5150

* Tweak Nunjucks colour to be allowed

* Revert color change

Was looking at old revision

* Add generated language ID for Nunjucks

* Move Nunjucks sample

* Add Nunjucks grammar entry

Keep using `python-django.tmbundle`

* Switch Nunjucks grammar

Now using alohaas/language-nunjucks

* Add language-nunjucks grammar to list

* Add language-nunjucks license

* Add source.nunjucks to list

* Fix grammar ordering

Co-authored-by: Colin Seymour <colin@github.com>
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
Co-authored-by: Nixinova <Nixinova@users.noreply.github.com>
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lildude @Alhadis @Nixinova