Ungroup major languages #4979
Merged
Ungroup major languages #4979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alhadis
requested review from
pchaigno and
lildude
and removed request for
pchaigno
This was referenced Aug 31, 2020
sambacha
pushed a commit
to freight-trust/linguist
that referenced
this pull request
Sep 4, 2020
This was referenced Feb 5, 2021
Merged
Merged
lildude
pushed a commit
that referenced
this pull request
Mar 19, 2021
* Split StringTemplates from HTML Was originally added in #1117 as a HTML variant, but per #4979 language variants should be split. Default to using default HTML grammar. Will add a heuristic to differentiate from Smalltalk if needed. * Fix StringTemplate name and colour * Rename StringTemplate sample * Add StringTemplate grammar to index Uses `atom/language-html`; not ideal as ST-unique syntax isn't matched * Add .st heuristic * Add .st heuristic test * Fix syntax error in heuristics tester * Generalise part of Smalltalk .st heuristic * Further fix to Smalltalk heuristic * Fix unescaped character * Remove single quote * Replace StringTemplate grammar module Using dangmarm/stringtemplate-lang now * Update StringTemplate grammar link dangmarm/stringtemplate-lang * Replace tm_scope `source.stringtemplate` * Register StringTemplate tm_scope * Add grammar license info * Revert "Replace StringTemplate grammar module" This reverts commit 7c3bce2. * Revert StringTemplate grammar addition * Minor fix to heuristic * Replace raw space with Regex space char * Allow whitespace at start of doc * Add ^ and ' as Smalltalk characters * Escape ' properly * More accurate regex * Change regex from \w+ to \w* * Add other delimiters to StringTemplate heuristic * Use grammar added in Alhadis/language-etc@f41e1a4 * Updated cached license data Co-authored-by: Nixinova <Nixinova@users.noreply.github.com> Co-authored-by: John Gardner <gardnerjohng@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4291 / Depends on: #4978
Status of related tasks:
Description
This pull-request ungroups languages listed in #4291, from which I'll quote the reason for doing so:
Note that this PR includes #4978 as part of its changes, so ensure that gets merged first before this one. The reason is that users will notice (and complain) if their repository stats are 60% grey because SCSS/Less are no longer grouped under CSS or what-have-you.
Checklist:
changingadding the colours associated with languages."Agreement" isn't the word I'd use, since these colours are already used by each language's official branding, making them canon by proxy.