-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Reason detection #4473
Fix Reason detection #4473
Conversation
We might want to add this to #4291. @Alhadis What do you think?
|
I'm not familiar with either OCaml or Reason, but it certainly sounds like grouping them was a mistake:
|
I think the issue is a very good initiative, maybe it would still be easier to do the job language by language?
The weirdest thing is that the extension has been added to the C++ ones in the same commit Reason was added in Linguist. Is there a way through linguist to detect with both source content and extension? |
Just an FYI: if a file extension has enough usage in-the-wild, it doesn't matter if it's "official" or not. If hundreds of repositories on GitHub associate an extension with a language, that's important enough for Linguist to consider, irrespective of whether a language deems it official. |
I don't agree with this. Reason is and has been OCaml from its inception. It's just a frontend to the OCaml compiler, insofar as after the first compiler pass you can't know whether your code was Reason or OCaml to begin with Additionally, Reason works with OCaml dependencies, and I'll go as far as saying it needs OCaml dependencies, given how more widespread the OCaml ecosystem of libraries is in comparison to Reason.
You may see it that way, but that's not true. You're using the OCaml compiler therefore I consider you an OCaml developer :)
This is a personal shortcoming which IMO is orthogonal to this argument. |
The community is disagreeing with this so I'm closing the pull request. |
Sorry I closed it very fast because it created a big debate in the community, we may come back here but for now we need a consensus. And @Alhadis for what I said about removing |
Reason is definitely just a syntax extension of OCaml. but if your opinion is reasonable for this project, TypeScript should be recognized as JavaScript. |
Same deal for Elixir/Erlang—there's a precedent for this already. Not having detection for the language hurts the growth of the community. I can't see the downside. |
Solved by #4713! |
.re
from C++ extensions.Description
This change is linked to the comment I made here: #3949 (comment)
On the ungroup of OCaml: Reason might be an extension of OCaml, it has its own identity. I'm a Reason developer I'm not an OCaml developer at all. I don't even know how to read OCaml properly and I work with Reason everyday. I really want the ability to give a ReasonML its "Reason" identity so I can find them in github trendings.
On the removal of .re in C++: I've been C++ developer and I never saw this extension. I just checked on cppreference and I don't see it either. It's colliding with the official Reason extension.
The overall idea is to have our ReasonML projects having a "Reason" identity, so we can share as we do with all the other languages.
Checklist: