Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reason from ocaml group #4713

Merged
merged 3 commits into from
Nov 28, 2019

Conversation

amiralies
Copy link
Contributor

Closes #4684

@amiralies
Copy link
Contributor Author

@jordwalke do you agree with this?

@jordwalke
Copy link

I think your argument about knowing how much of a repo is written in either Reason or OCaml is a nice feature. It would be cool if eventually there were some higher level Github/linguist feature available to be able to group based on language semantics and not just syntax, but until then I support this change.

@ryyppy
Copy link
Contributor

ryyppy commented Nov 28, 2019

Just to be sure to comply to the CONTRIBUTING guidelines:

Checklist

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

Goal was to display Reason as its own language instead of showing it as OCaml.
This is ready for review, the Reason community would be super happy to see this merged 😄

\cc @lildude

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 for this change.

However, you'll want to add a color to the language. Since it's not part of the OCaml group anymore, it will be displayed in the language statistics bar (in grey by default).

@ryyppy
Copy link
Contributor

ryyppy commented Nov 28, 2019

@pchaigno awesome, thanks for chiming in! I don't have push rights to this branch, but the Reason logo / most recognizable color in the Reason ecosystem is #dd4b39 (orange-red) .

@amiralies could you add this color to the Reason config?

@lildude lildude merged commit 74e5501 into github-linguist:master Nov 28, 2019
@amiralies amiralies deleted the reason-rem-group branch November 28, 2019 15:48
RawToast added a commit to RawToast/bouken that referenced this pull request Dec 9, 2019
Reason should be detected now thanks to: github-linguist/linguist#4713
@rafaelfess
Copy link

@ryyppy Why was it added as "Reason" instead of "ReasonML"?

@ryyppy
Copy link
Contributor

ryyppy commented Mar 20, 2020

Reason is the official language name, ReasonML is the "googleable name" afaik. kinda similarly on how go / rust call themselves rustlang / golang

@rafaelfess
Copy link

Thanks for the explanation, @ryyppy.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReasonML detected as Ocaml
6 participants