-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove reason from ocaml group #4713
Conversation
@jordwalke do you agree with this? |
I think your argument about knowing how much of a repo is written in either Reason or OCaml is a nice feature. It would be cool if eventually there were some higher level Github/linguist feature available to be able to group based on language semantics and not just syntax, but until then I support this change. |
Just to be sure to comply to the CONTRIBUTING guidelines: Checklist
Goal was to display Reason as its own language instead of showing it as OCaml. \cc @lildude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 👍 for this change.
However, you'll want to add a color to the language. Since it's not part of the OCaml group anymore, it will be displayed in the language statistics bar (in grey by default).
@pchaigno awesome, thanks for chiming in! I don't have push rights to this branch, but the Reason logo / most recognizable color in the Reason ecosystem is @amiralies could you add this color to the Reason config? |
it was too close with html's
Reason should be detected now thanks to: github-linguist/linguist#4713
@ryyppy Why was it added as "Reason" instead of "ReasonML"? |
Reason is the official language name, ReasonML is the "googleable name" afaik. kinda similarly on how go / rust call themselves rustlang / golang |
Thanks for the explanation, @ryyppy. |
Closes #4684