Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ungroup Mustache from HTML #5183

Merged
merged 3 commits into from
Feb 8, 2021
Merged

Ungroup Mustache from HTML #5183

merged 3 commits into from
Feb 8, 2021

Conversation

Nixinova
Copy link
Contributor

@Nixinova Nixinova commented Feb 5, 2021

Ungroups Mustache from HTML for consistency with all other templating languages per #4979.

Set colour to black as that is the only color used in the logo (site).

* Set colour to black as that is the only color used in the logo
@Nixinova Nixinova requested a review from a team as a code owner February 5, 2021 06:43
@Alhadis
Copy link
Collaborator

Alhadis commented Feb 5, 2021

Set colour to black as that is the only color used in the logo (site).

Try #724b3b instead. I'm not sure I could that a logo—it's merely the Georgia font's } glyph rotated 90º with CSS and presumably made #000000 to replace the #333333 inherited from the <body> element:

Figure 1

(I could ramble away about Gestalt's importance in graphic design, or how contrast is the device "black" logos use to establish visual identity, but I think you get the point…)

@Nixinova
Copy link
Contributor Author

Nixinova commented Feb 5, 2021

Where is #724b3b taken from?

@Alhadis
Copy link
Collaborator

Alhadis commented Feb 5, 2021

Where is #724b3b taken from?

Google images. Specifically, some random pixel buried in this bloke's moustache:

(Okay, so it wasn't random. I did adjust the saturation and intensity so it was more vibrant…)

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lildude lildude merged commit bd94d33 into github-linguist:master Feb 8, 2021
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants