Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PEG.js to use Peggy grammar #7018

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

spenserblack
Copy link
Contributor

Description

Continuation based on #7017 (comment)

According to a maintainer of Peggy (@hildjj), this grammar is backwards-compatible with PEG.js, and includes some new features. See peggyjs/peggy#544 (comment) and peggyjs/peggy#544 (comment).

I didn't replace the old grammar submodule since it seems to be a special case, providing syntaxes for multiple languages.

Checklist:

@spenserblack spenserblack requested a review from a team as a code owner August 28, 2024 16:50
lildude
lildude previously approved these changes Aug 29, 2024
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude changed the title Switch PEG.js TM Scope to source.peggy Change PEG.js to use Peggy grammar Aug 29, 2024
@lildude lildude added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 29, 2024
@lildude lildude added this pull request to the merge queue Aug 29, 2024
Merged via the queue into github-linguist:master with commit c0d3f3b Aug 29, 2024
5 checks passed
@spenserblack spenserblack deleted the grammar/peg.js branch August 29, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants