Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention gh_color_mode for directly uploaded images? #11491

Closed
ramyaparimi opened this issue Oct 27, 2021 · 5 comments
Closed

Mention gh_color_mode for directly uploaded images? #11491

ramyaparimi opened this issue Oct 27, 2021 · 5 comments
Labels
content This issue or pull request belongs to the Docs Content team good first issue Good for newcomers help wanted Anyone is welcome to open a pull request to fix this issue

Comments

@ramyaparimi
Copy link
Contributor

ramyaparimi commented Oct 27, 2021 •
edited
Loading

Discussed in https://github.com/github/docs/discussions/11479

Originally posted by Andre601 October 27, 2021
Just recently discovered that you can append gh_color_mode=light or gh_color_mode=dark to a githubusercontent.com hosted image to only show it while the user is using the respective mode.

I feel like this should be mentioned in the docs somewhere, probably under the markdown syntax docs in the images section, so that people are aware of it.

Edited by maintainer. Here is the writer's review for this issue.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 27, 2021
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 28, 2021
@lecoursen
Copy link
Member

I agree that "Basic writing and formatting syntax" is the best place to document this!

@lecoursen lecoursen added the help wanted Anyone is welcome to open a pull request to fix this issue label Oct 29, 2021
@ramyaparimi ramyaparimi removed the waiting for review Issue/PR is waiting for a writer's review label Nov 11, 2021
@ramyaparimi ramyaparimi added the good first issue Good for newcomers label Jan 26, 2022
@shreya024
Copy link

I would like to work on this issue. Kindly assign

@ramyaparimi
Copy link
Contributor Author

@shreya024 we generally don't assign issues. You are welcome to open a PR to an issue you would like to work one ✨ .

@shreya024 shreya024 mentioned this issue Mar 15, 2022
Closed
5 tasks
@shreya024
Copy link

@shreya024 we generally don't assign issues. You are welcome to open a PR to an issue you would like to work one ✨ .

Okay I have made a PR.Kindly review.

@guntrip
Copy link
Contributor

guntrip commented Mar 30, 2022

As I mentioned in the linked PR, it looks like this feature has already been documented since this issue was opened. I'm sorry for the confusion (and extra sorry to @shreya024 for the work put in!)

@guntrip guntrip closed this as completed Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team good first issue Good for newcomers help wanted Anyone is welcome to open a pull request to fix this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mentioned gh_color_mode in .md
6 participants
@guntrip @lecoursen @ramyaparimi @shreya024 and others