Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentioned gh_color_mode in .md #16266

Closed
wants to merge 2 commits into from
Closed

Mentioned gh_color_mode in .md #16266

wants to merge 2 commits into from

Conversation

shreya024
Copy link

@shreya024 shreya024 commented Mar 15, 2022

Why:

Closes #11491

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

edited by maintainer to correctly link the issue

@welcome
Copy link

welcome bot commented Mar 15, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
content/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax.md Modified Original

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels Mar 15, 2022
@ramyaparimi
Copy link
Contributor

@shreya024
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@shreya024
Copy link
Author

@shreya024 Thanks so much for opening a PR! I'll get this triaged for review ⚡

Okay thank you

@guntrip
Copy link
Contributor

guntrip commented Mar 30, 2022

Hi @shreya024! I'm really sorry but It looks like some crossed wires have lead to this feature already being documented. Take a look at the "Specifying the theme an image is shown to" section on the same page.

I'll have to close this (and the associated issue) but again, I'm really sorry. Your changes looked great and if it wasn't for this already being documented, I'd have been delighted to merge them! I hope you'll contribute again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention gh_color_mode for directly uploaded images?
3 participants