update eslint-plugin-graphql to 2.1.0 #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh
reviewed
Apr 19, 2018
| @@ -34,7 +34,7 @@ | |||
| "babel-eslint": ">=8.0.0", | |||
| "eslint-config-prettier": ">=2.6.0", | |||
| "eslint-plugin-flowtype": ">=2.36.0", | |||
| "eslint-plugin-graphql": ">=2.0.0", | |||
There was a problem hiding this comment.
Won't ">=2.0.0" already allow for 2.1?
There was a problem hiding this comment.
Oh lol that's a good point. I got all exicted and opened up the PR. This should just work™️ in devtools now?
There was a problem hiding this comment.
Hmm it's not updating on my machine:
☁ devtools [master] rm -rf node_modules
☁ devtools [master] npm install
> fsevents@1.1.3 install /Users/koddsson/github/devtools/node_modules/fsevents
> node install
[fsevents] Success: "/Users/koddsson/github/devtools/node_modules/fsevents/lib/binding/Release/node-v59-darwin-x64/fse.node" is installed via remote
> uglifyjs-webpack-plugin@0.4.6 postinstall /Users/koddsson/github/devtools/node_modules/uglifyjs-webpack-plugin
> node lib/post_install.js
added 1772 packages in 67.799s
☁ devtools [master] cat node_modules/eslint-plugin-graphql/package.json | jq .version
"2.0.0"There was a problem hiding this comment.
Oh I need to just refresh the package-lock.json in devtools I think.
There was a problem hiding this comment.
Yup that's it, I'll make a PR in devtools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the CHANGELOG:
Should fix a issue where CI is running real slow for one of the internal projects.