Skip to content

Commit

Permalink
Fix: array comparison breaks if using the environments plugin (#682)
Browse files Browse the repository at this point in the history
* update comments from #249

I found the logic behind some of what happened here hard to follow and updated the comments to try to make it easier to follow.

* fix environments updating global array

The environments plugin was changing `MergeDeep.NAME_FIELDS`, which is a global object. The reason was to avoid environments being filtered out from the change list if they only have a name field.
However, the environments plugin has it's own overriden sync method, and thus we can simply drop the whole filtering from that method.

Fixes #108

* remove repeating line

This has to be a "typo" from 9a74e05 calling the same assignment twice. Removing to clean up.
  • Loading branch information
torgst authored Sep 16, 2024
1 parent 610094d commit 85aae4f
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 85aae4f

Please sign in to comment.