Fix: array comparison breaks if using the environments plugin #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found the logic behind some of what happened here hard to follow and updated the comments to try to make it easier to follow.
The environments plugin was changing `MergeDeep.NAME_FIELDS`, which is a global object. The reason was to avoid environments being filtered out from the change list if they only have a name field. However, the environments plugin has it's own overriden sync method, and thus we can simply drop the whole filtering from that method. Fixes github#108
This has to be a "typo" from 9a74e05 calling the same assignment twice. Removing to clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this will solve what I think is a serious bug introduced in version 2.1.11 as reported in issue 108.
If I understand things correctly, loading the environment plugin removes the
namevalue from theMergeDeep.NAME_FIELDSarray and this again breaks merging arrays, thus leading to diff reporting not working as expected.I believe this change keeps the result of the fix that caused the bug, but in a way that removes the problem.
I also did a quick change at the end of
mergeDeep.jswhere this line was duplicated (I believe that must be just a slip):