Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check for updates #1397

Merged
merged 24 commits into from
Aug 5, 2024
Merged

feat: check for updates #1397

merged 24 commits into from
Aug 5, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jul 21, 2024

Based on #1395 from @bquorning

Draft PR to consider:

  • Adding a context menu for checking for updates manually
  • Adding a scheduled timer to check for updates automatically (not just on app start)
  • Display somewhere in the UI a visual indicator when there is a new version available

@github-actions github-actions bot added the enhancement New feature or enhancement to existing functionality label Jul 21, 2024
@github-actions github-actions bot added the dependency Dependency updates label Jul 22, 2024
@setchy
Copy link
Member Author

setchy commented Jul 22, 2024

Latest version
Screenshot 2024-07-22 at 10 30 23 AM

Update available
Screenshot 2024-07-22 at 10 31 19 AM

@setchy setchy marked this pull request as ready for review July 22, 2024 00:36
@setchy setchy added this to the Release 5.12.0 milestone Jul 22, 2024
@afonsojramos
Copy link
Member

Love the idea, but I think the implementation in the UI is a bit weird. The behaviour that I see in these menubar apps is usually an indicator in the icon of the menubar and I think it is less intrusive and more informative at the same time, what do you think?

Example: Ollama
image
image
image

@setchy
Copy link
Member Author

setchy commented Jul 22, 2024

Love the idea, but I think the implementation in the UI is a bit weird. The behaviour that I see in these menubar apps is usually an indicator in the icon of the menubar and I think it is less intrusive and more informative at the same time, what do you think?

Example: Ollama
image
image
image

I like that approach. Would you be interested in helping pivot this way?

@setchy
Copy link
Member Author

setchy commented Jul 22, 2024

I also like the restart to update context menu entry. That seems better than doing it automatically

@setchy
Copy link
Member Author

setchy commented Jul 22, 2024

UPDATE: split the following out into #1399


Another thought, maybe our menu system could adopt a hierarchy similar to this:

  • check for update
    -- show status if update available
    -- show restart to update if available
  • separator
  • Developer (sub menu)
    -- Reload
    -- Toggle Developer Tools
    -- separator
  • Quit

@setchy setchy marked this pull request as draft July 22, 2024 16:19
@setchy
Copy link
Member Author

setchy commented Jul 22, 2024

@afonsojramos - pushed updates to this branch that add the extra context menu elements.

Not sure the best way to update the tray icon. We'd either need to create a new png, or, manipulate the tray title (used for notification counts) to display a visual indicator

For now, I've used the tray title

Screenshot 2024-07-23 at 12 41 48 PM

@setchy setchy marked this pull request as ready for review July 22, 2024 23:08
@github-actions github-actions bot removed the dependency Dependency updates label Jul 23, 2024
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice

@setchy setchy merged commit 2f4ee9a into main Aug 5, 2024
12 checks passed
@setchy setchy deleted the feature/check-for-updates branch August 5, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants