Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve app update experience #1450

Merged
merged 8 commits into from
Aug 9, 2024
Merged

refactor: improve app update experience #1450

merged 8 commits into from
Aug 9, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Aug 8, 2024 •
edited
Loading

Iterate on the enhancements added in #1397

@setchy
refactor: use update-electron-app to control update experience
139f81e 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy added this to the Release 5.13.0 milestone Aug 8, 2024
@github-actions github-actions bot added dependency Dependency updates refactor Refactoring of existing feature labels Aug 8, 2024
@setchy
build: update lockfile
5d8f751 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
feat: add new icons for update available visualization
d5151ce 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
feat: add new icons for update available visualization
1baa6df 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
Copy link
Member Author

setchy commented Aug 8, 2024

Added new tray icons to show a visual indicator for "update available", as well as updating the tray tooltip

Idle Active
tray-idle-update@2x tray-active-update@2x

@setchy setchy marked this pull request as ready for review August 8, 2024 16:21
@setchy
feat: add new icons for update available visualization
67a979b 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy changed the title refactor: use update-electron-app to control update experience refactor: improve in-app update experience Aug 9, 2024
@setchy setchy changed the title refactor: improve in-app update experience refactor: improve app update experience Aug 9, 2024
@setchy
refactor: update experience
5b471a0 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: update experience
8848835 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
bmulholland
bmulholland reviewed Aug 9, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
bmulholland
bmulholland approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to use a lib for it, presumably they've thought it all through more than we have

@afonsojramos
Copy link
Member

Definitely way prettier 🚀

afonsojramos
afonsojramos approved these changes Aug 9, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/components/settings/SettingsFooter.tsx Show resolved Hide resolved
@setchy
fix dep versions
62dacea 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy merged commit d415f24 into main Aug 9, 2024
12 checks passed
@setchy setchy deleted the refactor/improve-update-exp branch August 9, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmulholland bmulholland bmulholland approved these changes

@afonsojramos afonsojramos afonsojramos approved these changes

Assignees
No one assigned
Labels
dependency Dependency updates refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 5.13.0
Development

Successfully merging this pull request may close these issues.

Arrow symbol in tray
3 participants
@setchy @afonsojramos @bmulholland