Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Jekyll redirect_from template from favicon check #448

Merged
merged 2 commits into from
Aug 28, 2017

Conversation

gjtorikian
Copy link
Owner

Closes #446, though it is extraordinarily brittle, there's not much else that can be done.

@codecov-io
Copy link

codecov-io commented Aug 27, 2017

Codecov Report

Merging #448 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   98.52%   98.52%   +<.01%     
==========================================
  Files          27       27              
  Lines        1758     1763       +5     
==========================================
+ Hits         1732     1737       +5     
  Misses         26       26
Impacted Files Coverage Δ
lib/html-proofer/check/favicon.rb 100% <100%> (ø) ⬆️
spec/html-proofer/favicon_spec.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 758396e...5d202a0. Read the comment docs.

@gjtorikian gjtorikian merged commit e1c259f into master Aug 28, 2017
@gjtorikian gjtorikian deleted the fix-favicon-on-redirect branch August 28, 2017 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants