Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust redirect detection #452

Merged
merged 5 commits into from
Sep 15, 2017
Merged

Conversation

Floppy
Copy link
Contributor

@Floppy Floppy commented Sep 14, 2017

An improvement on #448 that specifically checks for a zero-time refresh meta tag.

@codecov-io
Copy link

codecov-io commented Sep 14, 2017

Codecov Report

Merging #452 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   98.52%   98.52%   +<.01%     
==========================================
  Files          27       27              
  Lines        1763     1766       +3     
==========================================
+ Hits         1737     1740       +3     
  Misses         26       26
Impacted Files Coverage Δ
lib/html-proofer/check/favicon.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c259f...ca5f63f. Read the comment docs.

@gjtorikian gjtorikian merged commit 1f16b8b into master Sep 15, 2017
@gjtorikian gjtorikian deleted the more-robust-redirect-detection branch September 15, 2017 10:57
@gjtorikian
Copy link
Owner

Way better. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants