gh-170: add yamllint and run over the repo
#230
Conversation
paddyroddy
added
the
infrastructure
| rev: v1.35.1 | ||
| hooks: | ||
| - id: yamllint | ||
| args: |
There was a problem hiding this comment.
Is it possible to add these args as config in pyproject.toml? Looks good otherwise!
There was a problem hiding this comment.
Can always add "move some of the pre-commit config to pyproject" as a to-do item.
There was a problem hiding this comment.
Sorry this is my bad. These options have been tried and tested, but I have some hacky "global" pre-commit hooks, where I don't want to have the same config everywhere https://github.com/paddyroddy/.github/blob/main/precommit/general/general-hooks.yaml
There was a problem hiding this comment.
Is it possible to add these args as config in pyproject.toml? Looks good otherwise!
It's not by the way, but can add to a .yamllint.yaml file
There was a problem hiding this comment.
Ah, thanks for looking into this, keeping it as it is should be fine!
Saransh-cpp
changed the title
yamllint and run over the repoyamllint and run over the repo
Saransh-cpp
force-pushed
the
add-yamllint
branch
from
e1e7138
to
9a4f4da
Compare
|
Taking over 🫡 |
Closes #267. The main advantage here is when running the given tool it will always work, rather than just via `pre-commit`. Previously requested in #230 (comment). Have used `pyproject.toml` where possible.
Still working towards #170. The options seem like a lot but these are ones I've used and I've found great for readability. Plus, for example, removing Python versions makes diffs easier when doing something like
rather than