Use sha for interpolation replacement #391
Conversation
| i += 1 | ||
| "#{UNTRANSLATABLE_STRING}#{i}" | ||
| value.gsub INTERPOLATION_KEY_RE do |m| | ||
| Digest::SHA1.hexdigest m |
|
I'm not sure how robust this is: There is a chance that a substring of the SHA-1 hash is an actual word, which may confuse Google Translate. Perhaps we can simply use a different token, something other than |
|
While there may be a substring that is an actual word inside the hash, since the hash is being sent as one word, I don't believe it will attempt to translate it. Then again the entire point of this PR is because google translate is translating strange combinations of letters, or at least behaving strangely. So it's a good point. Using a token sounds like a plan, out of curiosity, why include any alphabet character at all? |
|
Closing in favor of #392 |
Without a character, the
|
Fixes #390
Uses a digest of the interpolation variable to replace/restore during translation rather than
zxzxzxplus a counter for the current interpolated variable. We will be sending more characters to google translate with this fix but this seemed an acceptable trade-off.