-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract formatting / lint changes from the Error Recovery PR, and add prettier to ci / local tooling #1500
Extract formatting / lint changes from the Error Recovery PR, and add prettier to ci / local tooling #1500
Conversation
turbo.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file was invalid, it's been fixed (had duplicate keys)
3a884bf
to
2944439
Compare
2944439
to
cc3061f
Compare
e34669b
to
748445c
Compare
@@ -21,9 +21,10 @@ | |||
"build:control": "rollup -c rollup.config.mjs", | |||
"build:flags": "RETAIN_FLAGS=true ember build --env production --suppress-sizes", | |||
"lint": "npm-run-all lint:*", | |||
"lint:format": "prettier -c .", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting wasn't being checked on C.I.... 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 on doing this separately in a single pass, obviously I can’t/didn’t review every file, but as long as this is all automated and without code changes then let’s do it!
…he linting job slow
…nning, doubling up on lint tasks
This is awesome! Thanks so much @NullVoxPopuli. For future reference, the current formatting rules assume that you're running the equivalent of The In vscode, the expectation is that saving a file will automatically run both eslint fixes and prettier. The settings checked in to |
Instead of: #1499
I figured it'd be better to extract the formatting changes from #1462
tl;dr:
master
feature/handle-error
to single commit without mergefeature/handle-error
git rebase origin/master
The way this'll work is we have a one time cost of "run prettier / eslint --fix once" on
master
, and get things in a predictable spot -- then on the error-recovery branch, we'll rebase / squash down to one commit, copy the lint configs from this branch (as the error recovery branch doesn't have passing lints atm, and some stuff is TODO'd / disabled), then we can run lint:fix over there -- then finally rebase on top ofmaster
-- the goal is to reduce the diff from both branches by getting everything formatting / linting the same.