-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract formatting / lint changes from the Error Recovery PR, and add prettier to ci / local tooling #1500
Merged
NullVoxPopuli
merged 6 commits into
master
from
extract-lint-changes-from-error-recovery-PR
Nov 22, 2023
Merged
Extract formatting / lint changes from the Error Recovery PR, and add prettier to ci / local tooling #1500
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cc3061f
Run prettier with lint:fix
NullVoxPopuli 748445c
Update lockfile
NullVoxPopuli 4cbd2d9
Remove dotenv from lint:files, this busts the turbo cache and makes t…
NullVoxPopuli 660405c
Disable a lint on one additional file
NullVoxPopuli 725a831
Don't bust the cache for turbo based on if is logging warnings or not…
NullVoxPopuli acf76d8
Addition of lint:fix for ci was accidentally running when lint was ru…
NullVoxPopuli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
|
||
node_modules/ | ||
|
||
# output directories | ||
dist/ | ||
ts-dist/ | ||
|
||
|
||
# We don't need prettier here | ||
*.md | ||
*.yaml | ||
*.yml | ||
guides/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,25 @@ | ||
{ | ||
"singleQuote": true, | ||
"trailingComma": "es5", | ||
"printWidth": 100 | ||
"printWidth": 100, | ||
"plugins": [], | ||
"overrides": [ | ||
{ | ||
"files": ["**/*.{js,ts,cjs,mjs,cts,mts,cts}"], | ||
"options": { | ||
"singleQuote": true, | ||
"trailingComma": "es5" | ||
} | ||
}, | ||
{ | ||
"files": ["*.json"], | ||
"options": { | ||
"singleQuote": false | ||
} | ||
}, | ||
{ | ||
"files": ["*.hbs"], | ||
"options": { | ||
"singleQuote": false | ||
} | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
{ | ||
"fsevents_latency": 0.02, | ||
"ignore_dirs": [ "tmp" ] | ||
"ignore_dirs": ["tmp"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<div class="container"> | ||
<table class="table table-hover table-striped test-data"><tbody> | ||
{{#each @items as |item|}}<Row @select={{this.select}} @item={{item}}/>{{/each}} | ||
</tbody></table> | ||
{{#each @items as |item|}}<Row @select={{this.select}} @item={{item}} />{{/each}} | ||
</tbody></table> | ||
<span className="preloadicon glyphicon glyphicon-remove" aria-hidden="true"></span> | ||
</div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,9 @@ | ||
<tr class={{if @item.selected "danger"}}> | ||
<td class="col-md-1">{{@item.id}}</td> | ||
<td class="col-md-4"><a {{on "click" this.onSelect}}>{{@item.label}}</a></td> | ||
<td class="col-md-1"><a><span class="glyphicon glyphicon-remove" aria-hidden="true"></span></a></td> | ||
<td class="col-md-1"><a><span | ||
class="glyphicon glyphicon-remove" | ||
aria-hidden="true" | ||
></span></a></td> | ||
<td class="col-md-6"></td> | ||
</tr> | ||
</tr> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
|
||
const express = require('express'); | ||
|
||
const app = express(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
|
||
const express = require('express'); | ||
|
||
const app = express(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 4 additions & 8 deletions
12
packages/@glimmer-workspace/benchmark-env/lib/benchmark/basic-component-manager.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/@glimmer-workspace/benchmark-env/lib/benchmark/create-env-delegate.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting wasn't being checked on C.I.... 🙃