add proposed selectionRange API #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marwes
reviewed
Mar 27, 2019
src/request.rs
Outdated
| @@ -108,6 +108,9 @@ macro_rules! lsp_request { | |||
| ("textDocument/typeDefinition") => { | |||
| $crate::request::GotoTypeDefinition | |||
| }; | |||
| ("textDocument/selectionRange") => { | |||
| $crate::request::SelectionRange | |||
There was a problem hiding this comment.
yeah...
I hate how some of these are XRequest and some are just X, but this inconsistent naming comes from the protocol itself.
I wonder if "maintaining consistency with inconsistent protocol" is worth it...
There was a problem hiding this comment.
Whatever makes it easier I think. I'd recommend using the macros to refer to them in most cases anyway since that reflects their actual RPC name. So the name of the underlying type shouldn't matter most of the time.
matklad
force-pushed
the
selection-range
branch
from
3a439bd
to
1141faa
Compare
matklad
force-pushed
the
selection-range
branch
3 times, most recently
from
9878f00
to
6e37d45
Compare
|
@Marwes marked as ready for review: the protocol extension is still provisional, but is released and usable: |
matklad
force-pushed
the
selection-range
branch
from
6e37d45
to
6b8b717
Compare
|
Good idea, fixed! |
|
Released as 0.57.1 |
|
It seems like this is a semver breaking change? rls can't build with 0.57.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proposes extension to the protocol, which looks like it's going to be stabilized soon.
See microsoft/vscode-languageserver-node#474
Let's not merge the PR until it is set in stone though