151: Make (locale) compatible with Anki 2.1.22 and up #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support Anki 2.1.x
same problem as https://github.com/glutanimate/anki-addons-misc/issues/38 code taken from fix glutanimate/anki-addons-misc@b68b8cb fixes glutanimate#46
Fix encoding error in pathname2url on python3
This is necessary for changes to image files to become visible in the EditCurrent and Browser editor instances. Fixes glutanimate#62
Allows us to experiment with different svg-edit versions
This implements a new method which grants us the limited possibility of performing in-place changes to the card template without discarding any potential changes that the user might have performed.
Up to this point the add-on config/templates would only be set up upon user interaction (e.g. creating new I/O notes or changing options). This commit will allows us to update the note type before a user has the chance to interact with potentially outdated notes/cards. (of importance for instance with the switch to Anki 2.1, where updates to the card templates are needed for the cards to render correctly in the Reviewer)
Fixes glutanimate#45. Most likely also fixes glutanimate#15. Even with a liberal fadein timer set, the image flashing problem would still persist on slower systems and/or systems that have performance issues with the new web engine (macOS?). Postponing image visibility until after the mask is loaded seems like the only surefire way to prevent instances of the answers flashing before the actual answer reveal. We still use a small aFade timer to make transitions between question and answer where the images have not been cached smoother. Because this change comes with a lot of increased complexity to the basic method of operation of the add-on, and because it has the potential to completely disrupt card reviewing, it will require extensive testing across all platforms (especially the mobile clients and AnkiWeb).
Now that we only have two modes left, it makes sense to explore more intuitive labels that are still close enough to the previous ones to not confuse existing users. (thanks to tmbb for the suggestion!)
Might be worthwhile to look into using Anki's own dialog manager for I/O editor instances at some point.
Fix version number
…-crash Fix issue glutanimate#95 (crash in in-group editing mode)
Change how clipboard images are saved.
DONE: + profile_did_open + editor_did_init_buttons + editor_will_show_context_menu (fixes glutanimate#151) TODO: + Editor.setNote + Reviewer._showAnswer + reviewStateShortcuts + browser.setupMenus + unloadProfile
…apability 124: Add localisation support
Just to get the add-on running again
Add-on currently not in working state
* Keep downwards compatibility until 2.1.15 * Idea for fix from @5hir0kur0 * Run `black` on `src/image_occlusion_enhanced/lang.py`
Noxgrim
changed the title
Noxgrim
force-pushed
the
151-locale-compatible-with-current-anki
branch
from
018a1a3
to
6d96f70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The patch introduced in #125 does not work with current Versions of Anki (2.1.26).
I tried to fix this according to this comment from @glutanimate.
I introduced the fix proposed by @5hir0kur0 in their comment and added backward compatibility by checking whether the needed function exists.
I also ran
blackon the changed file.Checklist:
(Additionally 2.1.{15,16,22,24})