Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

151: Make (locale) compatible with Anki 2.1.22 and up #155

Open
wants to merge 113 commits into
base: main
Choose a base branch
from

Commits on Dec 9, 2017

  1. Merge pull request glutanimate#43 from dae/master

    Support Anki 2.1.x
    glutanimate authored Dec 9, 2017
    Configuration menu
    Copy the full SHA
    e36d74d View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2018

  1. Fix options dialog

    glutanimate committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    dbe897c View commit details
    Browse the repository at this point in the history
  2. Update .gitignore

    glutanimate committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    9264113 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2018

  1. Configuration menu
    Copy the full SHA
    bf5a2b9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request glutanimate#49 from khonkhortisan/patch-1

    Fix encoding error in pathname2url on python3
    glutanimate authored Feb 25, 2018
    Configuration menu
    Copy the full SHA
    90311b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2018

  1. Configuration menu
    Copy the full SHA
    1003ca1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8d1c6a View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2018

  1. Configuration menu
    Copy the full SHA
    a7dcb55 View commit details
    Browse the repository at this point in the history
  2. Run pylint and autopep8

    glutanimate committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    d5d7468 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    20a43cf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0173582 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2018

  1. Update gitignore

    glutanimate committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    8e13c29 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b49d363 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6304b7b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1e5c6c5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    972f54c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ad6035a View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2018

  1. Configuration menu
    Copy the full SHA
    8679432 View commit details
    Browse the repository at this point in the history
  2. Force editor.Editor reload after I/O note editing

    This is necessary for changes to image files to become visible in
    the EditCurrent and Browser editor instances.
    
    Fixes glutanimate#62
    glutanimate committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    397985f View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2018

  1. Switch to version-agnostic svg-edit path

    Allows us to experiment with different svg-edit versions
    glutanimate committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    dacafaf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc85b92 View commit details
    Browse the repository at this point in the history
  3. Ability to perform incremental updates to templates

    This implements a new method which grants us the limited possibility
    of performing in-place changes to the card template without discarding
    any potential changes that the user might have performed.
    glutanimate committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    303d3eb View commit details
    Browse the repository at this point in the history
  4. Set up add-on configuration and templates at profile initialization

    Up to this point the add-on config/templates would only be set up
    upon user interaction (e.g. creating new I/O notes or changing options).
    This commit will allows us to update the note type before a user has
    the chance to interact with potentially outdated notes/cards.
    
    (of importance for instance with the switch to Anki 2.1, where
    updates to the card templates are needed for the cards to render
    correctly in the Reviewer)
    glutanimate committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    cdb2631 View commit details
    Browse the repository at this point in the history
  5. Only load original image after mask loading has completed

    Fixes glutanimate#45. Most likely also fixes glutanimate#15.
    
    Even with a liberal fadein timer set, the image flashing problem
    would still persist on slower systems and/or systems that have
    performance issues with the new web engine (macOS?).
    Postponing image visibility until after the mask is loaded
    seems like the only surefire way to prevent instances of the answers
    flashing before the actual answer reveal.
    
    We still use a small aFade timer to make transitions between question
    and answer where the images have not been cached smoother.
    
    Because this change comes with a lot of increased complexity to the
    basic method of operation of the add-on, and because it has the potential
    to completely disrupt card reviewing, it will require extensive
    testing across all platforms (especially the mobile clients and
    AnkiWeb).
    glutanimate committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    7be290d View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2018

  1. Update UI build task

    glutanimate committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    6aa60e7 View commit details
    Browse the repository at this point in the history
  2. Relabel note generation modes

    Now that we only have two modes left, it makes sense to explore more
    intuitive labels that are still close enough to the previous ones
    to not confuse existing users. (thanks to tmbb for the suggestion!)
    glutanimate committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    7f3fd9a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8b2693e View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2018

  1. Configuration menu
    Copy the full SHA
    1c30ea9 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2018

  1. Configuration menu
    Copy the full SHA
    d7c680b View commit details
    Browse the repository at this point in the history
  2. Make sure to close dialogs before Anki exits (fixes glutanimate#68)

    Might be worthwhile to look into using Anki's own dialog manager
    for I/O editor instances at some point.
    glutanimate committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    b7fba1a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2018

  1. Fix extension button font

    glutanimate committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    715df1e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c6f9cbc View commit details
    Browse the repository at this point in the history
  3. Only show SVG-Edit once ready. New ImgOccEdit instance on each edit.

    By delaying web view rendering until SVG-Edit is fully up and running,
    we eliminate most of the perceived glitchiness on Anki 2.1 (glutanimate#55.)
    
    Switching to a multi-instance model has been long overdue. Aside from
    contributing to the fix for image flashing regression (glutanimate#55), it will
    likely also address a number of longstanding problems that users
    experienced after longer I/O sessions (SVG-Edit malfunctioning, or
    stopping to work entirely after too many image changes).
    
    Previous attempts at refactoring the add-on in a similar way had failed
    because of issues with memory management (6d222df). This commit finally
    introduces proper clean up and garbage collection which surprisingly
    seems to work perfectly in QtWebEngine as opposed to QtWebKit
    (though I might have just learned how to handle objects in Python
    a bit better since my last attempt 2 years ago)
    glutanimate committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    2f7e41a View commit details
    Browse the repository at this point in the history
  4. Call fitImageCanvas on changing image (resolves glutanimate#42)

    With fitImageCanvas now using a JS timer, automatically fitting images
    to the canvas finally works.
    glutanimate committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    5048951 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bfe6339 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f5f7885 View commit details
    Browse the repository at this point in the history
  7. Run autopep8

    glutanimate committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    6dac389 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b0acf81 View commit details
    Browse the repository at this point in the history
  9. Call exporer.exe instead of using os.startfile

    os.startfile is complaining about missing file associations, even though
    they appear to be set.
    glutanimate committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    9d2f956 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2018

  1. Don't assign parent to ImgOccEdit instances

    This partially resolves glutanimate#76. Seems like this change has no noticeable
    ill effects on memory management.
    glutanimate committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    a092283 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a960d1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    12eb009 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2018

  1. Update docs

    glutanimate committed Jul 21, 2018
    Configuration menu
    Copy the full SHA
    0e8cd86 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2018

  1. Configuration menu
    Copy the full SHA
    97eaeaa View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. Quick hotfix for Anki 2.1 compatibility

    2.1's Python dist no longer ships with uuid
    (partially reverts 5908e13)
    glutanimate committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    ad49e6d View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2018

  1. Revert 5908e13

    Anki now ships uuid again.
    
    Seems like packaging uuid locally might have also caused some
    problems on macOS. Hopefully this fixes those.
    glutanimate committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    dc6662b View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. Merge pull request glutanimate#88 from zjosua/no-editorwebview

    Don't try to reload ed.web whent it's None.
    glutanimate authored Mar 22, 2019
    Configuration menu
    Copy the full SHA
    496b559 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Configuration menu
    Copy the full SHA
    98063cc View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2019

  1. Add manifest file

    glutanimate committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    597f517 View commit details
    Browse the repository at this point in the history
  2. Update .gitignore

    glutanimate committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    5f98f4d View commit details
    Browse the repository at this point in the history
  3. Update manifest

    glutanimate committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    b28dbc9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3ba94f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2019

  1. Configuration menu
    Copy the full SHA
    e3d60a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15ee9a2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ebb2148 View commit details
    Browse the repository at this point in the history
  4. Tweak logo size

    glutanimate committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    a0404e5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    678261f View commit details
    Browse the repository at this point in the history
  6. Tweak README

    glutanimate committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    8defe0d View commit details
    Browse the repository at this point in the history
  7. Use 2.1 name

    glutanimate committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    1641241 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    17a9bb8 View commit details
    Browse the repository at this point in the history
  9. beta → stable

    glutanimate committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    061975b View commit details
    Browse the repository at this point in the history
  10. Tweak README

    glutanimate committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    4506fc5 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2019

  1. Save clipboard images as jpg by default.

    Add option to save clipboard images as png.
    zjosua committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    14f762b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2cc1470 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. Fix typos

    glutanimate committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    f2439a4 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. Move vendorized packages to _vendor, drop PIL, add imghdr

    We were shipping a non-working version of PIL anyway that had been
    mangled in the 2to3 conversion step last year
    
    Due to the extension restrictions in the file selector dialog,
    imageProp almost never had to fall back to PIL, and so this issue
    remained undiscovered until now
    glutanimate committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    e711c8a View commit details
    Browse the repository at this point in the history
  2. Refactor image identification, making it more robust and expressive

    thanks to Audrey for inspiring this change
    glutanimate committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    b75f9f5 View commit details
    Browse the repository at this point in the history
  3. Update CHANGELOG

    glutanimate committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    12aaabd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    953b91a View commit details
    Browse the repository at this point in the history
  5. Fix CHANGELOG links

    glutanimate committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    0b77124 View commit details
    Browse the repository at this point in the history
  6. Fix additions_by_version data type

    Fixes TypeError when updating template (thanks to Emma for the report)
    glutanimate committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    a4e0157 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. Fix issue glutanimate#95 (crash in in-group editing mode)

    This fixes the issue by calling leaveContext() before the calls
    to svgCanvasToString(). leaveContext() returns from a group context
    to the normal one.
    5hir0kur0 committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    18bbcd9 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2019

  1. 128: Add localisation support

    This fixes issue glutanimate#123
    
    - Surround (most) translatable Strings with 'gettext' calls
    - Change format Strings
    - Remove '_cardS()'
    * Kept most translations from 'main.py'
    + Add 'lang.py'
    + Add skeleton file, generated by `xgettext`
    Noxgrim committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    bd10bd3 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2020

  1. 124: Add German translation and move old file to .pot file

    + Add complete German translation
    
    * Fix missing ‘>’ in 'dialogs.py' (“<b>Fixing a broken note type:</b\n”)
    
    * Move 'src/image_occlusion_enhanced/locale/de/LC_MESSAGES/anki-image-occlusion-enhanced.po'
      to   'src/image_occlusion_enhanced/locale/anki-image-occlusion-enhanced.pot'
    * Change file paths in comments of po(t) files
    Noxgrim committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    f6b75dd View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2020

  1. 124: Remove unused references to multi threading

    * Only use local variables because the multi threading
      is only really useful for Anki
    * Update the modification comment
    Noxgrim committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    7ea76b3 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2020

  1. Fix version number

    Thanks to @BlueGreenMagick for the pointer!
    glutanimate committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    87f7798 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Configuration menu
    Copy the full SHA
    509acb4 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Merge pull request glutanimate#139 from zjosua/query-quotes

    Use double quotes in queries and don't quote the field name individually
    glutanimate authored Apr 6, 2020
    Configuration menu
    Copy the full SHA
    de0a8a8 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. Change config access

    zjosua committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    b794a51 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Configuration menu
    Copy the full SHA
    ae2a7aa View commit details
    Browse the repository at this point in the history
  2. Merge pull request glutanimate#143 from zjosua/config-db

    Change config access
    glutanimate authored Apr 13, 2020
    Configuration menu
    Copy the full SHA
    9522c0c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5245961 View commit details
    Browse the repository at this point in the history
  4. Merge pull request glutanimate#146 from glutanimate/revert-143-config-db

    Revert "Change config access"
    glutanimate authored Apr 13, 2020
    Configuration menu
    Copy the full SHA
    4cad106 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Configuration menu
    Copy the full SHA
    13326c6 View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG

    glutanimate committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    bb716f8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aacc32a View commit details
    Browse the repository at this point in the history
  4. Fix version number

    davidculley committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    7148db9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cf781a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Configuration menu
    Copy the full SHA
    751b5ec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5942527 View commit details
    Browse the repository at this point in the history
  3. Merge pull request glutanimate#122 from 5hir0kur0/issue-95-ctrl-enter…

    …-crash
    
    Fix issue glutanimate#95 (crash in in-group editing mode)
    glutanimate authored Jun 4, 2020
    Configuration menu
    Copy the full SHA
    960107b View commit details
    Browse the repository at this point in the history
  4. Merge pull request glutanimate#105 from zjosua/paste-png

    Change how clipboard images are saved.
    glutanimate authored Jun 4, 2020
    Configuration menu
    Copy the full SHA
    39e8d71 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4caab1b View commit details
    Browse the repository at this point in the history
  6. Begin migrating to new hook system

    DONE:
    
    + profile_did_open
    + editor_did_init_buttons
    + editor_will_show_context_menu (fixes glutanimate#151)
    
    TODO:
    
    + Editor.setNote
    + Reviewer._showAnswer
    + reviewStateShortcuts
    + browser.setupMenus
    + unloadProfile
    glutanimate committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    1352003 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9c30461 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    762b642 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0dd33c1 View commit details
    Browse the repository at this point in the history
  10. Update .gitignore

    glutanimate committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    99f8e63 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e0b4ab1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    df8b1c2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8ec07be View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    61e76f4 View commit details
    Browse the repository at this point in the history
  15. Fix remaining headers

    glutanimate committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    f830e46 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    59564f5 View commit details
    Browse the repository at this point in the history
  17. Merge pull request glutanimate#125 from Noxgrim/124-add-translation-c…

    …apability
    
    124: Add localisation support
    glutanimate authored Jun 4, 2020
    Configuration menu
    Copy the full SHA
    95e8193 View commit details
    Browse the repository at this point in the history
  18. Run "black"

    glutanimate committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    80ea5a2 View commit details
    Browse the repository at this point in the history
  19. Bump to dev version

    glutanimate committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    c1766a2 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. Configuration menu
    Copy the full SHA
    4480b28 View commit details
    Browse the repository at this point in the history
  2. Vendor libaddon

    glutanimate committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    bcb2cc1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6db16be View commit details
    Browse the repository at this point in the history
  4. Temporarily replace lang.currentLang with lang.currentLang

    Just to get the add-on running again
    glutanimate committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    6e05330 View commit details
    Browse the repository at this point in the history
  5. Package SVG-Edit 5.1.0

    Add-on currently not in working state
    glutanimate committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    b2efb40 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2020

  1. 151: Make compatible with Anki 2.1.22 and up

    * Keep downwards compatibility until 2.1.15
    * Idea for fix from @5hir0kur0
    * Run `black` on `src/image_occlusion_enhanced/lang.py`
    Noxgrim committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    6d96f70 View commit details
    Browse the repository at this point in the history