-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: namespaces concepts page #1909
Conversation
Hey @leohhhn. I have added the basic info about namespaces and package/realm path. Didn't talked much about namespaces, because things are not finalised yet. Just included the link to the issue. I don't know much about other blockchain systems. So can't add the comparison. Maybe you can take it from here 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @harry-hov. I left some minor comments.
Please also include the namespaces file in the concepts section in misc/docusaurus/sidebars.js
, and try to do yarn build
& yarn start
to see how the page looks when its deployed (and so that I can do that as well).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1909 +/- ##
==========================================
- Coverage 47.74% 45.34% -2.41%
==========================================
Files 393 464 +71
Lines 61637 68416 +6779
==========================================
+ Hits 29430 31021 +1591
- Misses 29736 34804 +5068
- Partials 2471 2591 +120 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good after changes
Adds info about the namespaces and package/realm path.
Adds info about the namespaces and package/realm path.