Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: namespaces concepts page #1909

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Apr 9, 2024

Adds info about the namespaces and package/realm path.

@harry-hov harry-hov marked this pull request as ready for review April 10, 2024 19:21
@harry-hov harry-hov requested a review from a team as a code owner April 10, 2024 19:21
@harry-hov
Copy link
Contributor Author

Hey @leohhhn. I have added the basic info about namespaces and package/realm path. Didn't talked much about namespaces, because things are not finalised yet. Just included the link to the issue.

I don't know much about other blockchain systems. So can't add the comparison. Maybe you can take it from here 🙏

Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @harry-hov. I left some minor comments.

Please also include the namespaces file in the concepts section in misc/docusaurus/sidebars.js, and try to do yarn build & yarn start to see how the page looks when its deployed (and so that I can do that as well).

docs/concepts/namespaces.md Outdated Show resolved Hide resolved
docs/concepts/namespaces.md Outdated Show resolved Hide resolved
docs/concepts/namespaces.md Outdated Show resolved Hide resolved
docs/concepts/namespaces.md Outdated Show resolved Hide resolved
docs/concepts/namespaces.md Outdated Show resolved Hide resolved
docs/concepts/namespaces.md Show resolved Hide resolved
docs/concepts/namespaces.md Outdated Show resolved Hide resolved
@harry-hov harry-hov requested a review from a team as a code owner April 16, 2024 10:05
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.34%. Comparing base (59c6d3e) to head (dffb722).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1909      +/-   ##
==========================================
- Coverage   47.74%   45.34%   -2.41%     
==========================================
  Files         393      464      +71     
  Lines       61637    68416    +6779     
==========================================
+ Hits        29430    31021    +1591     
- Misses      29736    34804    +5068     
- Partials     2471     2591     +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leohhhn leohhhn changed the title docs: namespaces and pkg/realm path docs: namespaces concepts page Apr 16, 2024
docs/concepts/namespaces.md Show resolved Hide resolved
docs/concepts/namespaces.md Outdated Show resolved Hide resolved
docs/concepts/namespaces.md Outdated Show resolved Hide resolved
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good after changes

@harry-hov harry-hov merged commit 229bf0e into gnolang:master Apr 16, 2024
181 checks passed
omarsy pushed a commit to TERITORI/gno that referenced this pull request Apr 16, 2024
Adds info about the namespaces and package/realm path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants