Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stdlibs/std): use appropriate variable names for regex #2106

Merged
merged 1 commit into from
May 16, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented May 14, 2024

Introduced in #875, but only managed to review after it was merged

(cc/ @r3v4s)

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 48.84%. Comparing base (a901e79) to head (0f93f8a).

Files Patch % Lines
gnovm/stdlibs/std/banker.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2106      +/-   ##
==========================================
- Coverage   48.84%   48.84%   -0.01%     
==========================================
  Files         579      579              
  Lines       78015    78015              
==========================================
- Hits        38109    38106       -3     
- Misses      36820    36821       +1     
- Partials     3086     3088       +2     
Flag Coverage Δ
gnovm 42.08% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harry-hov harry-hov merged commit 3c37507 into master May 16, 2024
149 of 151 checks passed
@harry-hov harry-hov deleted the dev/morgan/specific-regex branch May 16, 2024 16:06
leohhhn pushed a commit to leohhhn/gno that referenced this pull request May 21, 2024
…#2106)

Introduced in gnolang#875, but only managed to review after it was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants