Skip to content

Commit

Permalink
chore(stdlibs/std): use appropriate variable names for regex (gnolang…
Browse files Browse the repository at this point in the history
…#2106)

Introduced in gnolang#875, but only managed to review after it was merged.
  • Loading branch information
thehowl authored and leohhhn committed May 21, 2024
1 parent f20e052 commit 4bbf429
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions gnovm/stdlibs/std/banker.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ const (
)

// regexp for denom format
const denomRegex = "[a-z][a-z0-9]{2,15}"

var reg = regexp.MustCompile(denomRegex)
var reDenom = regexp.MustCompile("[a-z][a-z0-9]{2,15}")

func X_bankerGetCoins(m *gno.Machine, bt uint8, addr string) (denoms []string, amounts []int64) {
coins := m.Context.(ExecContext).Banker.GetCoins(crypto.Bech32Address(addr))
Expand Down Expand Up @@ -96,9 +94,9 @@ func X_bankerIssueCoin(m *gno.Machine, bt uint8, addr string, denom string, amou
// gno checks for bt == RealmIssue

// check origin denom format
matched := reg.MatchString(denom)
matched := reDenom.MatchString(denom)
if !matched {
m.Panic(typedString("invalid denom format to issue coin, must be " + denomRegex))
m.Panic(typedString("invalid denom format to issue coin, must be " + reDenom.String()))
return
}

Expand All @@ -112,9 +110,9 @@ func X_bankerIssueCoin(m *gno.Machine, bt uint8, addr string, denom string, amou
func X_bankerRemoveCoin(m *gno.Machine, bt uint8, addr string, denom string, amount int64) {
// gno checks for bt == RealmIssue

matched := reg.MatchString(denom)
matched := reDenom.MatchString(denom)
if !matched {
m.Panic(typedString("invalid denom format to remove coin, must be " + denomRegex))
m.Panic(typedString("invalid denom format to remove coin, must be " + reDenom.String()))
return
}

Expand Down

0 comments on commit 4bbf429

Please sign in to comment.