Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] - In the Context Menu(Right-Click) show keyboard shortcuts / accelarators #662

Closed
vssdeo opened this issue Oct 31, 2022 · 4 comments

Comments

@vssdeo
Copy link
Contributor

vssdeo commented Oct 31, 2022

Sometimes remembering short-cuts is handy though in case user forgets, one have to go and check keybindings. It would be handy to display the key shortcuts beside the menu item.

Currently I don't see the short-cut keys visible while I right-click the context menu. This is a standard feature in all other terminal emulators.

  • I have a patch ready in case this seems suggestion seems ok and accepted.
  • The patch takes the action from config and updates the menu dynamically

Note: I think there is a bug or discrepancy where for the action edit window title config.py says: 'edit_window_title': 'w where as in code: terminal_popup_menu.py
item = Gtk.ImageMenuItem.new_with_mnemonic(_('Set W_indow Title'))

Character i is selected as mnemonic.

  • In the patch I have fixed it to Character w as per the config.py
@vssdeo
Copy link
Contributor Author

vssdeo commented Oct 31, 2022

attachment after applying the patch

image0

vssdeo added a commit to vssdeo/terminator that referenced this issue Oct 31, 2022
…eyboard shortcuts / accelarators gnome-terminator#662

- added short cuts / accelarators to right click context menu
- menu is updated from config so changes in preferences keybindings appear dynamically
- Note: I think there is a bug or discrepancy where
        for the action edit window title config.py says:
            'edit_window_title': 'w where as in code: terminal_popup_menu.py
            item = Gtk.ImageMenuItem.new_with_mnemonic(_('Set W_indow Title'))
            Character i is selected as mnemonic.
- fixed the above discrepancy
@mattrose
Copy link
Member

Ooo, I like it. I'll pull it in and check it out soon

vssdeo added a commit to vssdeo/terminator that referenced this issue Nov 1, 2022
- added a filter to the preferences menu for easy access to shortcuts
- may require some tweak, on search term size and update
Note: when edited in prefs it seems the Short Cut Labes in (right click) Context Menu are not updated will fix that in that bug Issue gnome-terminator#662
@vssdeo
Copy link
Contributor Author

vssdeo commented Nov 1, 2022

was pushing #559 and found a bug, I didn't push it with that bug since this belongs here.

Note: when edited in prefs it seems the Short Cut Labels in (right click) Context Menu are not updated will fix that in that bug Issue #662

@vssdeo
Copy link
Contributor Author

vssdeo commented Nov 1, 2022

The problem in displaying is happening as the the config the key for eg Control is being saved as and the short cut alphabetic character is being picked when creating the menu item and not being overwritten from config. Will check further and fix since this thing is new to me.

vssdeo added a commit to vssdeo/terminator that referenced this issue Nov 1, 2022
…eyboard shortcuts / accelarators gnome-terminator#662

-fixed: The problem in displaying is happening as the the config the key for eg Control is being saved as <Primary> and the short cut alphabetic character is being picked when creating the menu item and not being overwritten from config
-Note: the short cut for function keys are not being displayed in context-menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants