Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug 662] [Feature Request] - In the Context Menu(Right-Click) show k… #663

Conversation

vssdeo
Copy link
Contributor

@vssdeo vssdeo commented Oct 31, 2022

…eyboard shortcuts / accelarators #662

  • added short cuts / accelarators to right click context menu
  • menu is updated from config so changes in preferences keybindings appear dynamically
  • Note: I think there is a bug or discrepancy where for the action edit window title config.py says: 'edit_window_title': 'w where as in code: terminal_popup_menu.py item = Gtk.ImageMenuItem.new_with_mnemonic(_('Set W_indow Title')) Character i is selected as mnemonic.
  • fixed the above discrepancy

…eyboard shortcuts / accelarators gnome-terminator#662

- added short cuts / accelarators to right click context menu
- menu is updated from config so changes in preferences keybindings appear dynamically
- Note: I think there is a bug or discrepancy where
        for the action edit window title config.py says:
            'edit_window_title': 'w where as in code: terminal_popup_menu.py
            item = Gtk.ImageMenuItem.new_with_mnemonic(_('Set W_indow Title'))
            Character i is selected as mnemonic.
- fixed the above discrepancy
@mattrose
Copy link
Member

I love it. Merged. Thanks so much for all of your help on this and the project as a whole.

@mattrose mattrose merged commit 1aa437d into gnome-terminator:master Oct 31, 2022
@vssdeo
Copy link
Contributor Author

vssdeo commented Oct 31, 2022

Sharpening my own tool ! when nothing else to do ! a selfish act :) Not without a great support from your side ! You are most welcome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants