Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug 559] Add menu autocomplete #559 #665

Merged
merged 2 commits into from
Nov 19, 2022

Commits on Nov 1, 2022

  1. [bug 559] Add menu autocomplete gnome-terminator#559

    - added a filter to the preferences menu for easy access to shortcuts
    - may require some tweak, on search term size and update
    Note: when edited in prefs it seems the Short Cut Labes in (right click) Context Menu are not updated will fix that in that bug Issue gnome-terminator#662
    vssdeo committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    fdcf8fa View commit details
    Browse the repository at this point in the history
  2. [bug 559] Add menu autocomplete

    Follwing errors were being thrown:
    
    FAILED tests/test_prefseditor_keybindings.py::test_keybinding_successfully_reassigned_after_clearing[accel_params0] - AttributeError: 'TreeModelFilter' object has no attribute 'set'
    
    It seems earlier the Gtk.ListStore()  was directly being passed in the test cases. After the changes to the Preferences to add a search filter bar we had added a filter Gtk.TreeModelFilter and for the widget we were setting it:
            widget.set_model(self.treemodelfilter)
    
    Now it seemed that instead of Gtk.ListStore() the object Gtk.TreeModelFilter was being received and since it did not have a "set" function the above error was thrown.
    
    I have made changes so that the Gtk.ListStore() is taken from Gtk.TreeModelFilter via get_model function and this indirection is removed.
    vssdeo committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    d08cee4 View commit details
    Browse the repository at this point in the history