This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis automatic deployment: |
anxolin
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Velenir
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really like how reusable useDataFilter
is 👍
alfetopito
reviewed
Jun 11, 2020
1. memoised all the things (necessary) 2. export handlers obj 3. logic opt - cleaner readability
alfetopito
approved these changes
Jun 12, 2020
* grab token details inside useOrders 1. use service 2. populate here to filter later 3. created DetailedAuctionElement type * remove async logic of fetching tokens from OrderRow inside fetchTokens * export BalanceTools * pass BalanceTools and DetauledAuction/PendingElement into OrdersWidget * get detailed info from pendingOrders hook * BalanceTools added with cehckbox and css changed to keep box on top * added FormMessage to show filter amount 1. added useDataFilter to OrderWidget * CSS: removed duped code, added styling * css fix on text color FormMessage * move BalanceTools into FilterTools component 1. re-add h5 title to TradeWidget (was removed to try adding as prop) * Add FilterTools to DepositWidget * add FilterTools to OrdersWidget + misc changes 1. add isWidget prop to flag smaller size * prop isWidget * simplify filter fn * include data-order-id to each tr * added id filtering 1. made filtering into fn for ease * fixed dataFiter props after rebase * DepositWidget: show filter results on search * Promise.all inside useOrder/PendingOrders * FilterTools resultName prop * move inline CSS to OrdersWidget.styled * fix missing border-radius for trade pg * use correct TokenDetails from `types` * no need for cast after fixed TokenDetails * return null custom filter fn on empty string thanks @Velenir * use TokenDetails from types
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes what used to be this code inside
DepositWidget/index
for filtering into:into
From the
useDataFilter
hookWill reuuse this logic inside
OrdersWidget
so made sense to move into own fileThough I am not sure if this is the cleanest of even a necessary implementation so feedback obv welcome