1032/filter tokens orders widget #1097
Conversation
|
Travis automatic deployment: |
I didn't add it here since users will look up 1 token at a time ussually? or no? i can re-add it Clarification: i only added the filter to the hide-zero-balance toggle, not the search filter |
|
Additional comment (discussed in the chat): Can we also include |
There was a problem hiding this comment.
Loved the filtered count detail.
Small points though:
- Why is the right side border rounded up instead of rounded down? I would expect it to round away from the search bar
(edit: just noticed on Anxo's image it's rounded as I would expect. FF problems, then...) - It should say
ordersinstead oftokens
1. use service 2. populate here to filter later 3. created DetailedAuctionElement type
1. added useDataFilter to OrderWidget
1. re-add h5 title to TradeWidget (was removed to try adding as prop)
1. add isWidget prop to flag smaller size
1. made filtering into fn for ease
W3stside
force-pushed
the
1032/filter-tokens-orders-widget
branch
from
1c37028 to
8dcb855
Compare
|
I still see it upside down :/
|
|
@alfetopito fixed it, wasn't moz related but dumb (me) related, good catch! |
Still there. Do you have anything local pending |
indeed ;) |
* filteredOrders -> classifiedOrders (name change) * useSearchFilter hook * useDataFilter as a more generic hoook instead of 2 hooks: useHideData and useSearchFilter * add filters to DepositWidget * dont use event on filter toggle * removed useHideZero * useDataFilter: PR comments addressed 1. memoised all the things (necessary) 2. export handlers obj 3. logic opt - cleaner readability * memoised filter params, better filter logic * 1032/filter tokens orders widget (#1097) * grab token details inside useOrders 1. use service 2. populate here to filter later 3. created DetailedAuctionElement type * remove async logic of fetching tokens from OrderRow inside fetchTokens * export BalanceTools * pass BalanceTools and DetauledAuction/PendingElement into OrdersWidget * get detailed info from pendingOrders hook * BalanceTools added with cehckbox and css changed to keep box on top * added FormMessage to show filter amount 1. added useDataFilter to OrderWidget * CSS: removed duped code, added styling * css fix on text color FormMessage * move BalanceTools into FilterTools component 1. re-add h5 title to TradeWidget (was removed to try adding as prop) * Add FilterTools to DepositWidget * add FilterTools to OrdersWidget + misc changes 1. add isWidget prop to flag smaller size * prop isWidget * simplify filter fn * include data-order-id to each tr * added id filtering 1. made filtering into fn for ease * fixed dataFiter props after rebase * DepositWidget: show filter results on search * Promise.all inside useOrder/PendingOrders * FilterTools resultName prop * move inline CSS to OrdersWidget.styled * fix missing border-radius for trade pg * use correct TokenDetails from `types` * no need for cast after fixed TokenDetails * return null custom filter fn on empty string thanks @Velenir * use TokenDetails from types
Closes #1032
Dependent on #1094
To test: head to
/ordersor/tradepage and filter tokens by address/symbol/nameuseOrders:useEffectand replaceOrderRow's previous responsibility on thisDetailedAuctionElementinterface which isAuctionElement+TokenDetailsfor bothbuyTokenandsellTokenFilter at work -
/orders:/trade: