Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing yourself from an organization should require a confirmation dialog #16215

Closed
2 of 3 tasks
fnetX opened this issue Jun 20, 2021 · 1 comment · Fixed by #16471
Closed
2 of 3 tasks

Removing yourself from an organization should require a confirmation dialog #16215

fnetX opened this issue Jun 20, 2021 · 1 comment · Fixed by #16471
Assignees
@thegeorgeous
Labels
good first issue Likely to be an easy fix hacktoberfest topic/ui Change the appearance of the Gitea UI

Comments

@fnetX
Copy link
Contributor

fnetX commented Jun 20, 2021

Description

A user on Codeberg reported perse accidentally left the "Owners" team of an organization, as this requires no confirmation, and thus the whole organization with no chance, to regain access after a single mistaken click.

As many other things do require confirmation, and these buttons are quite easy to hit ("Leave", or removing the wrong member), this should have a confirmation dialog IMHO, too.

Thank you for considering a fix. ✌️
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Jun 20, 2021
@6543 6543 added hacktoberfest good first issue Likely to be an easy fix labels Jun 23, 2021
@thegeorgeous
Copy link

thegeorgeous commented Jun 29, 2021 •
edited
Loading

@techknowlogick @6543
I would like to work on this. Can I pick it up?

zeripath added a commit to zeripath/gitea that referenced this issue Jul 17, 2021
@zeripath
Add modals to Organization and Team remove/leave
aa9cd80 
Add confirmation modals to Organization and Team remove and leave.

Fix go-gitea#16215

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Jul 17, 2021
Merged
techknowlogick added a commit that referenced this issue Aug 27, 2021
@zeripath @6543
@silverwind @techknowlogick
Add modals to Organization and Team remove/leave (#16471)
e37342d 
* Add modals to Organization and Team remove/leave

Add confirmation modals to Organization and Team remove and leave.

Fix #16215

Signed-off-by: Andrew Thornton <art27@cantab.net>

* avoid for-in

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Revert "avoid for-in"

This reverts commit 2af9a6f.

* Apply suggestions from code review

Co-authored-by: silverwind <me@silverwind.io>

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thegeorgeous thegeorgeous

Labels
good first issue Likely to be an easy fix hacktoberfest topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add modals to Organization and Team remove/leave zeripath/gitea
4 participants
@techknowlogick @thegeorgeous @fnetX @6543