Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modals to Organization and Team remove/leave #16471

Merged
merged 15 commits into from
Aug 27, 2021
Merged

Add modals to Organization and Team remove/leave #16471

merged 15 commits into from
Aug 27, 2021

Conversation

zeripath
Copy link
Contributor

Add confirmation modals to Organization and Team remove and leave.

Fix #16215

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Add modals to Organization and Team remove/leave
aa9cd80 
Add confirmation modals to Organization and Team remove and leave.

Fix go-gitea#16215

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Jul 17, 2021
@zeripath zeripath added this to the 1.16.0 milestone Jul 17, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 17, 2021
@zeripath zeripath mentioned this pull request Jul 17, 2021
Closed
6543
6543 reviewed Jul 17, 2021
View reviewed changes
routers/web/org/teams.go Show resolved Hide resolved
routers/web/org/teams.go Show resolved Hide resolved
6543
6543 approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no other concerns & works

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 17, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
lafriks
lafriks reviewed Jul 21, 2021
View reviewed changes
web_src/js/index.js Outdated Show resolved Hide resolved
lafriks
lafriks reviewed Jul 21, 2021
View reviewed changes
web_src/js/index.js Outdated Show resolved Hide resolved
@zeripath zeripath requested a review from lafriks July 22, 2021 21:50
@zeripath
Copy link
Contributor Author

I've moved back to of as per @silverwind

silverwind
silverwind reviewed Jul 26, 2021
View reviewed changes
web_src/js/index.js Outdated Show resolved Hide resolved
silverwind
silverwind reviewed Jul 26, 2021
View reviewed changes
web_src/js/index.js Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 26, 2021
@techknowlogick techknowlogick merged commit e37342d into go-gitea:main Aug 27, 2021
@zeripath zeripath deleted the organization-modals branch August 27, 2021 06:22
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@silverwind silverwind silverwind approved these changes

@lafriks lafriks Awaiting requested review from lafriks

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

Removing yourself from an organization should require a confirmation dialog
7 participants
@zeripath @codecov-commenter @silverwind @lafriks @6543 @techknowlogick @GiteaBot