Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open external wiki on the same page, if it is part of the repository. #20657

Closed
MorsMortium opened this issue Aug 3, 2022 · 0 comments · Fixed by #20725
Closed

Open external wiki on the same page, if it is part of the repository. #20657

MorsMortium opened this issue Aug 3, 2022 · 0 comments · Fixed by #20725
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@MorsMortium
Copy link

Feature Description

I have a project in which the wiki is accessible from the app, and so it is part of the repo. I have set the link to the file as external wiki. It opens and displays as expected, with the exception, that it opens in a new page, unlike built-in wikis.
Examples, on Codeberg:

This could either be checked by gitea, or setable in the settings, where the wiki is set. I could not find any similar issues here.

Screenshots

No response
@MorsMortium MorsMortium added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Aug 3, 2022
Gusted pushed a commit to Gusted/gitea that referenced this issue Aug 9, 2022
Don't open new page for ext wiki on same repository
6fce04b 
- When the external wiki has been set to a file on the repository, don't
open the page on a tab.
- Resolves go-gitea#20657
@Gusted Gusted mentioned this issue Aug 9, 2022
Merged
zeripath pushed a commit that referenced this issue Aug 20, 2022
Don't open new page for ext wiki on same repository (#20725)
3d52edc 
- When the external wiki has been set to a file on the repository, don't
open the page on a tab.
- Resolves #20657
Gusted pushed a commit to Gusted/gitea that referenced this issue Aug 22, 2022
Don't open new page for ext wiki on same repository (go-gitea#20725)
b5485ca 
- Backport of go-gitea#20725
  - When the external wiki has been set to a file on the repository, don't open the page on a tab.
  - Resolves go-gitea#20657
@Gusted Gusted mentioned this issue Aug 22, 2022
Merged
techknowlogick pushed a commit that referenced this issue Aug 22, 2022
@zeripath
Don't open new page for ext wiki on same repository (#20725) (#20910)
c0754e9 
* Don't open new page for ext wiki on same repository (#20725)

- Backport of #20725
  - When the external wiki has been set to a file on the repository, don't open the page on a tab.
  - Resolves #20657

* Gofmt

* Fix line

Co-authored-by: zeripath <art27@cantab.net>
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 28, 2022
Don't open new page for ext wiki on same repository (go-gitea#20725)
bc767db 
- When the external wiki has been set to a file on the repository, don't
open the page on a tab.
- Resolves go-gitea#20657
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't open new page for ext wiki on same repository Gusted/gitea
1 participant
@MorsMortium