Don't open new page for ext wiki on same repository #20725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gusted
commented
Aug 9, 2022
Gusted
commented
- When the external wiki has been set to a file on the repository, don't open the page on a tab.
- Resolves Open external wiki on the same page, if it is part of the repository. #20657
- When the external wiki has been set to a file on the repository, don't open the page on a tab. - Resolves go-gitea#20657
silverwind
approved these changes
Aug 9, 2022
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Aug 20, 2022
GiteaBot
added
lgtm/done
|
@Gusted what's the reasoning behind backporting? |
|
My idea of backports were bug fixes + small enchantments. At least that's what I had observed so far. |
|
I guess this is fine and small enough. Please send the backport. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 22, 2022
* giteaofficial/main: update current stable version [skip ci] Updated translations via Crowdin Fix mirror address setting not working (go-gitea#20850) Support Proxy protocol (go-gitea#12527) Fix SQL Query for `SearchTeam` (go-gitea#20844) Double check CloneURL is acceptable (go-gitea#20869) Fix graceful doc (go-gitea#20883) Pad GPG Key ID with preceding zeroes (go-gitea#20878) [skip ci] Updated translations via Crowdin call builtinUnused() if internal SSH is disabled (go-gitea#20877) Don't open new page for ext wiki on same repository (go-gitea#20725) [skip ci] Updated translations via Crowdin Fix the mode of custom dir to 0700 in docker-rootless (go-gitea#20861) Fix UI mis-align for PR commit history (go-gitea#20845)
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Aug 22, 2022
- Backport of go-gitea#20725 - When the external wiki has been set to a file on the repository, don't open the page on a tab. - Resolves go-gitea#20657
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
- When the external wiki has been set to a file on the repository, don't open the page on a tab. - Resolves go-gitea#20657
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.