Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent CI Failure TestPersistableChannelUniqueQueue #23977

Closed
lunny opened this issue Apr 7, 2023 · 2 comments · Fixed by #23753
Closed

Intermittent CI Failure TestPersistableChannelUniqueQueue #23977

lunny opened this issue Apr 7, 2023 · 2 comments · Fixed by #23753
Labels
type/bug type/testing

Comments

@lunny
Copy link
Member

lunny commented Apr 7, 2023

Description

ok  	code.gitea.io/gitea/modules/public	0.100s	coverage: 7.7% of statements

2023/04/07 10:45:59 ...ueue_channel_test.go:169:func3() [I] Finally terminating

2023/04/07 10:45:59 ...eue/queue_channel.go:129:func1() [W] ChannelQueue: test-queue-channel Terminated before completed flushing

2023/04/07 10:46:00 ...disk_channel_test.go:202:func1() [I] [642ff468-2] pausing

2023/04/07 10:46:01 ...disk_channel_test.go:202:func1() [I] [642ff468-4] pausing

2023/04/07 10:46:01 ...disk_channel_test.go:257:func3() [I] Finally terminating

TempDir /tmp/TestPersistableChannelUniqueQueue1161295328/001

2023/04/07 10:46:03 ...ueue_disk_channel.go:314:Shutdown() [W] [642ff46a-7] PersistableChannelUniqueQueue: QueueB 79 will be restored on restart

panic: send on closed channel


goroutine 361 [running]:

code.gitea.io/gitea/modules/queue.(*WorkerPool).pushBoost(0xc0008c0750, {0x103fd60, 0xc00023dbe0})

	/drone/src/modules/queue/workerpool.go:153 +0xb6

code.gitea.io/gitea/modules/queue.(*WorkerPool).Push(0xc0008c0750, {0x103fd60, 0xc00023dbe0})

	/drone/src/modules/queue/workerpool.go:108 +0x1f9

code.gitea.io/gitea/modules/queue.(*ChannelUniqueQueue).PushFunc(0xc000329340, {0x103fd60, 0xc00023dbe0}, 0x0)

	/drone/src/modules/queue/unique_queue_channel.go:143 +0x2bd

code.gitea.io/gitea/modules/queue.(*PersistableChannelUniqueQueue).PushFunc(0xc0003292d0, {0x103fd60, 0xc00023dbe0}, 0x48a05b?)

	/drone/src/modules/queue/unique_queue_disk_channel.go:153 +0x130

code.gitea.io/gitea/modules/queue.(*PersistableChannelUniqueQueue).Push(0xc002205baf?, {0x103fd60, 0xc00023dbe0})

	/drone/src/modules/queue/unique_queue_disk_channel.go:144 +0x54

code.gitea.io/gitea/modules/queue.NewPersistableChannelUniqueQueue.func2({0xc000272e50, 0x1, 0x10?})

	/drone/src/modules/queue/unique_queue_disk_channel.go:105 +0xf9

code.gitea.io/gitea/modules/queue.NewByteFIFOUniqueQueue.func1({0xc000272e50, 0x1, 0x1})

	/drone/src/modules/queue/queue_bytefifo.go:398 +0x93

code.gitea.io/gitea/modules/queue.(*WorkerPool).FlushWithContext(0xc0002b0f30, {0x25137c8, 0xc000276140})

	/drone/src/modules/queue/workerpool.go:503 +0x4c9

code.gitea.io/gitea/modules/queue.(*WorkerPool).Flush(0x4889ac?, 0x48a05b?)

	/drone/src/modules/queue/workerpool.go:458 +0xaf

code.gitea.io/gitea/modules/queue.(*ByteFIFOQueue).Flush(0xc0002be000, 0x396c120?)

	/drone/src/modules/queue/queue_bytefifo.go:150 +0xc5

code.gitea.io/gitea/modules/queue.(*PersistableChannelUniqueQueue).Run.func4()

	/drone/src/modules/queue/unique_queue_disk_channel.go:219 +0xdf

created by code.gitea.io/gitea/modules/queue.(*PersistableChannelUniqueQueue).Run

	/drone/src/modules/queue/unique_queue_disk_channel.go:216 +0x6f2

FAIL	code.gitea.io/gitea/modules/queue	3.668s

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

run the CI

Database

None
@lunny lunny added the type/bug label Apr 7, 2023
@silverwind
Copy link
Member

Long-standing issue. Should fix or disable.

@silverwind silverwind changed the title CI randomly failed Intermittent CI Failure TestPersistableChannelUniqueQueue Apr 7, 2023
@wxiaoguang
Copy link
Contributor

And this one?

@silverwind silverwind mentioned this issue Apr 29, 2023
Merged
silverwind added a commit that referenced this issue Apr 29, 2023
@silverwind
Skip known flaky queue tests on CI environment (#24419)
fc62992 
Random CI failures are annoying. It's better to just skip the affected
tests so maintainers can use their valuable time for more productive
topics.

Related: #23608
Related: #23977
Related: #18703
@silverwind silverwind mentioned this issue May 3, 2023
Merged
silverwind pushed a commit that referenced this issue May 4, 2023
@zeripath @KN4CK3R
Fix intermittent CI failure in EmptyQueue (#23753)
ad8631c 
The ordering of the final token causing a close of the queue in this
test may be out of sync due to concurrency. Instead just use ensure that
the queue is closed when everything expected is done.

Fixes: #23608
Fixes: #23977

---------

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug type/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix intermittent CI failure in EmptyQueue zeripath/gitea
3 participants
@lunny @silverwind @wxiaoguang