-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip known flaky queue
tests on CI environment
#24419
Conversation
queue
testsqueue
tests on CI environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Fixes"
Could keep the issues open so they won't be completely forgotten. |
I would propose to rewrite the queue code. |
Sure, fixing the bug (whether it is in test or code) is always better, but I think at some point our patience regarding waiting on such a fix must end. 😆 Issue is these bugs don't reproduce locally, for me at least, making debugging them hard. |
If enough people would approve, I can rewrite it (it won't be too long IMO) |
Let's wait with this PR then, maybe a week max. |
I think it's also good to take this one, to save merger's time. It doesn't harm anything IMO. |
Backporting as well because issue shows up on 1.19 as well of cource. |
I was unable to create a backport for 1.19. @silverwind, please send one manually. 🍵 |
Backport of #24419 to 1.19.
Random CI failures are annoying. It's better to just skip the affected tests so maintainers can use their valuable time for more productive topics.
Related: #23608
Related: #23977
Related: #18703