Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for redis v7 (via go-redis upgrade) #24113

Closed
pat-s opened this issue Apr 13, 2023 · 0 comments · Fixed by #24114
Closed

Support for redis v7 (via go-redis upgrade) #24113

pat-s opened this issue Apr 13, 2023 · 0 comments · Fixed by #24114
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Milestone
1.19.2

Comments

@pat-s
Copy link
Member

pat-s commented Apr 13, 2023

Feature Description

Redis v7 seems to require go-redis >= 9.0 as this version includes some important redis 7.0 fixes.

One of them is redis/go-redis#2110, which adds support for a connection string change in redis 7.0 which prevents from connection to redis-cluster instances of >= 7.0.

gitea 2023/04/13 20:00:47 routers/init.go:61:mustInit() [F] code.gitea.io/gitea/modules/cache.NewContext failed: got 4 elements in cluster info address, expected 2 or 3

The corresponding issue is redis/go-redis#2085 which then links to the PR mentioned above.
The current version in use is v8.11.5: https://github.com/go-gitea/gitea/blob/main/go.mod#L47

Screenshots

No response
@pat-s pat-s added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/upstream This is an issue in one of Gitea's dependencies and should be reported there labels Apr 13, 2023
techknowlogick added a commit to techknowlogick/gitea that referenced this issue Apr 13, 2023
@techknowlogick
Update redis library to support redis v7
44d6148 
Fix go-gitea#24113
@techknowlogick techknowlogick mentioned this issue Apr 13, 2023
Merged
@pat-s pat-s mentioned this issue Apr 13, 2023
Closed
@lunny lunny added this to the 1.19.2 milestone Apr 14, 2023
pat-s pushed a commit to pat-s/gitea that referenced this issue Apr 16, 2023
@techknowlogick @pat-s
Update redis library to support redis v7
91507e9 
Fix go-gitea#24113
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Projects
None yet
Milestone
1.19.2
Development

Successfully merging a pull request may close this issue.

Update redis library to support redis v7 techknowlogick/gitea
Update go-redis to v9 pat-s/gitea
2 participants
@lunny @pat-s