-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redis library to support redis v7 #24114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dang I was a few seconds too slow in #24113 😅 Yes, I have a current dev environment in which I am trying to connect to a redis 7 cluster using Gitea dailies. |
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Apr 13, 2023
Closed
delvh
approved these changes
Apr 13, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Apr 13, 2023
Built an image from this branch and can confirm that connectivity to a redis-cluster works now! 🎉 |
pat-s
approved these changes
Apr 13, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 13, 2023
delvh
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 13, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 13, 2023
lunny
added
the
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
label
Apr 14, 2023
I was unable to create a backport for 1.19. @techknowlogick, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
No power to the bots! Create your backport yourself!
label
Apr 14, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 14, 2023
* upstream/main: Fix incorrect server error content in RunnersList (go-gitea#24118) [skip ci] Updated translations via Crowdin Improve git log for debugging (go-gitea#24095) Update redis library to support redis v7 (go-gitea#24114) Refactor cookie (go-gitea#24107) Fix admin team access mode value in team_unit table (go-gitea#24012) Add monospace toggle button to textarea (go-gitea#24034) Correct the access log format (go-gitea#24085) Changelog v1.19.1 (go-gitea#24079) (go-gitea#24092)
delvh
added
backport/done
All backports for this PR have been created
and removed
backport/manual
No power to the bots! Create your backport yourself!
labels
Apr 16, 2023
techknowlogick
added a commit
that referenced
this pull request
Apr 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24113
@pat-s could you test this PR to confirm it works with redis v7 clusters?