Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pictures in wiki acting just like pictures in main project.git #4395

Closed
a7hybnj2 opened this issue Jul 7, 2018 · 4 comments · Fixed by #5814
Closed

Pictures in wiki acting just like pictures in main project.git #4395

a7hybnj2 opened this issue Jul 7, 2018 · 4 comments · Fixed by #5814
Labels

Comments

@a7hybnj2
Copy link

a7hybnj2 commented Jul 7, 2018

Allow Picture in the WIKI #4376

No I did not mean to make it easier. I did indeed upload pictures to the wiki via git and referenced those pictures with MD in the wiki files. This resulted in a logon popup to be displayed while accessing that page. When moving the same image and md file to my main project.git directory I was not prompted for a logon.

@gsantner
Copy link

gsantner commented Jul 9, 2018

The refs in general seem to have stopped working. Mirroring e.g. https://github.com/mattdelfante/Blackjack makes all images disappear.

Image ref on gitea resolves to https://%gitea%/BlackJack/readMeImages/inGamePicOne.PNG, which does not exist.Works fine on GitHub

@a7hybnj2
Copy link
Author

a7hybnj2 commented Jul 9, 2018

In my case I had a folder "content" with the pictures in it then the .md would look at that folder. When I have the .md file and "content" on the .git side of things it works just fine. but If I mv/cp that same .md file and content folder to the wiki side it doesn't work and I get hit with a logon prompt which even if I logon it still doesn't seem to work.

I have also tried having the content on the .git side and having the wiki.md reference that but, I could not get that to work either.

@stale
Copy link

stale bot commented Jan 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 18, 2019
@a7hybnj2
Copy link
Author

What don't close it. It is still an ongoing issue. There just has been no progress made. More issues referencing this same issue have been made since this one.

Bad Bot!

@stale stale bot removed the issue/stale label Jan 18, 2019
techknowlogick pushed a commit that referenced this issue Feb 6, 2019
* Fix serving of raw wiki files other than .md

Closes #4690.
Closes #4395.

Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>

* Simplify code at routers/repo/wiki.go

Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>

* Add more files to user2/repo1.wiki for testing

Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>

* Update macaron to v1.3.2

Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>

* Add tests for WikiRaw

Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>

* Fix NewResponseWriter usage due to macaron update

Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>

* Add raw to reserved wiki names

Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants