-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serving of raw wiki files other than .md #5814
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5814 +/- ##
==========================================
+ Coverage 38.7% 38.74% +0.04%
==========================================
Files 330 330
Lines 48642 48650 +8
==========================================
+ Hits 18825 18850 +25
+ Misses 27090 27071 -19
- Partials 2727 2729 +2
Continue to review full report at Codecov.
|
Is there any easy way you can write a test of this functionality? (I suspect you've got the same problem I have in #5787 for making tests.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code includes some repeated lines. It maybes more clear?
Sorry for the force push, hope it didn't mess up anything. I simplified the code, @lunny, please check if that is ok for you. I feel like if I simplified it further things would get a little confused. EDIT: I'll try working on a test. |
Added tests. Had to update macaron due to a bug that made |
Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>
Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>
Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>
Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>
Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>
Signed-off-by: Gabriel Silva Simões <simoes.sgabriel@gmail.com>
@lunny, I think it is all set, except for the changes you requested. |
@lunny last ping before dismissing your review ;) |
Closes #4690.
Closes #4395.
This is a step towards #574, but maybe a GUI could also be implemented.
Signed-off-by: Gabriel Silva Simões simoes.sgabriel@gmail.com