Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploads on the wiki #574

Open
Tracked by #4
Fastidious opened this issue Jan 3, 2017 · 33 comments
Open
Tracked by #4

Uploads on the wiki #574

Fastidious opened this issue Jan 3, 2017 · 33 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@Fastidious
Copy link

Fastidious commented Jan 3, 2017

While we can upload files on issues, we can't on the wiki. Could this be implemented?

Want to back this issue?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@lunny lunny added this to the 1.1.0 milestone Jan 5, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 5, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Jan 6, 2017

IIRC this was being worked on for the new web-editor. But I could be mistaken

@Fastidious
Copy link
Author

Fastidious commented Jan 8, 2017

@bkcsoft got a link? I would assume this needs more than a web-editor.

@bkcsoft
Copy link
Member

bkcsoft commented Jan 9, 2017

@lunny
Copy link
Member

lunny commented Jan 25, 2017

Why he close that PR?

@lunny lunny modified the milestones: 1.2.0, 1.1.0 Jan 25, 2017
@lunny
Copy link
Member

lunny commented Jan 26, 2017

bountysource.com, but there are some bugs.

@lunny lunny modified the milestones: 1.x.x, 1.2.0 Apr 19, 2017
@onewhaleid
Copy link

What is the status of this?

@lunny
Copy link
Member

lunny commented Feb 17, 2018

Nobody are working on this.

@Fastidious
Copy link
Author

Bounty posted. Small, but I hope someone claims their cup of coffee!

@rlogiacco
Copy link

I added a beer, hopefully, drank before the coffee 😄

@windware-ono
Copy link

Linking to Gogs' issue. Hopefully someone on either side can get it done.
gogs/gogs#2263

Added to the bounty.

@gabrielsimoes
Copy link
Contributor

gabrielsimoes commented Jan 20, 2019

I'd like to try tackling this issue.

Are the uploads supposed to be treated like issue attachments or uploaded to the wiki repo?

EDIT: more info on the two options at gogs/gogs#2263

@rlogiacco
Copy link

rlogiacco commented Jan 20, 2019 via email

@Fastidious
Copy link
Author

I'd like to try tackling this issue.

Are the uploads supposed to be treated like issue attachments or uploaded to the wiki repo?

EDIT: more info on the two options at gogs/gogs#2263

Upload to wiki repository, and link it to wiki page, just like it is possible on Gtihub issues, for example.

@lunny
Copy link
Member

lunny commented Jan 22, 2019

@rlogiacco issue attachments has been implemented already.

@Fastidious
Copy link
Author

@lunny he wasn’t referring to issues attachments directly. He was asking how should uploads be implemented on wiki.

@lunny
Copy link
Member

lunny commented Jan 23, 2019

@Fastidious maybe someone could give some UI design ideas? Or just like gitea did on issue comment?

@windware-ono
Copy link

I don't see a problem using the same UI as the issues. Maybe add an icon in the toolbar for file uploads.

@gabrielsimoes
Copy link
Contributor

#5814 already allows for manually uploading images to repo.wiki and referencing them using /wiki/raw/*. Once it gets merged, I will work on a UI for that.

@gabrielsimoes
Copy link
Contributor

I need some input: should users be allowed to upload files to folders inside the wiki repo? Or only to the root folder?

@Fastidious
Copy link
Author

@gabrielsimoes for neatness, and organisational purposes, I prefer to upload to directories within the wiki repository. But why not just allow uploads to the wiki repository, without imposing location restrictions?

@gabrielsimoes
Copy link
Contributor

Uploading to directories by cloning the wiki repo has always been allowed. The only problem was that /wiki/raw/ had a bug restraining it from serving the files.

I'm currently implementing the UI interface for uploading files to the wiki. Should it allow uploads to specific folders inside the wiki repo? If so, implementing it would involve expanding some of the internal repo code to wiki repos.

@Fastidious
Copy link
Author

Should it allow uploads to specific folders inside the wiki repo?

Since this is to upload files, and use them on the web interface, would using a set directory to hold all uploads be a good idea then? Similar to how issues does it (i.e., /attachments/088cd773-c443-4e46-98f3-6f7f32d678b5).

@techknowlogick
Copy link
Member

As wiki is a repo, I think we should do exactly how we do file uploads on the standard repos, in that it adds a binary file to the underlying git repo. I would like to avoid putting them on server, as that would separate the file from the wiki itself (plus migrations/clones wouldn't include the file). I think LFS would be a good place to put the files, however not all servers have LFS enable, and so that is why I ended up thinking directly in the root of the repo as the place to put them. Please let me know if you need clarification on the wall of text I just wrote.

@Fastidious
Copy link
Author

@gabrielsimoes how goes? Let me know if there is something I can do to make this happen!

@stale stale bot added the issue/stale label Apr 8, 2019
@techknowlogick techknowlogick added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Apr 8, 2019
@go-gitea go-gitea deleted a comment from stale bot Apr 8, 2019
@Cherrg
Copy link
Contributor

Cherrg commented Jun 18, 2019

I have summed up the tasks here #6975 (comment)

@Fastidious
Copy link
Author

Fastidious commented Jan 27, 2020

We passed the three years mark on this one 🤧. As a reminder, there is a $150 bounty on it.

@windware-ono
Copy link

Anyone?

I've doubled the bounty to $300.
If no one would take it, I'll withdraw by the end of the year.

@BLumia
Copy link
Member

BLumia commented Jul 20, 2020

Since I also need this feature so I'm trying to implement this feature. Here are some progress I made and current implementation can be seen at #12279.

Screenshots about file upload

wikipage
uploadpage

The current state should just works but I still get some issue not have been solved since I'm not so familiar with the gitea codebase. So it's not ready to merge/use right now. Also since I can only try to work on this feature on my free time, so I probably still need some time to get the feature implemented properly...

@ivptr
Copy link

ivptr commented Dec 22, 2022

I found two pull requests for this issue: #6024 and #12279

@lunny any chance to check them out? Thanks.

@lunny
Copy link
Member

lunny commented Dec 23, 2022

Currently nobody are working on that PRs

@lunny lunny removed this from the 1.x.x milestone Mar 20, 2023
@brtwrst
Copy link

brtwrst commented May 30, 2024

for me, this is the one thing that keeps wikis from being useful. Reeally hope this happens at some point.

@Fastidious
Copy link
Author

Seven years, and it almost feels like yesterday. Time does fly!

@GlitchedPolygons
Copy link

for me, this is the one thing that keeps wikis from being useful. Reeally hope this happens at some point.

same. I wish I had the time to do it myself and work on a PR 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging a pull request may close this issue.