Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] on 500 error only show message if gitea in dev mode #11641

Merged
merged 9 commits into from
Jun 3, 2020
Merged

[API] on 500 error only show message if gitea in dev mode #11641

merged 9 commits into from
Jun 3, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented May 27, 2020 •
edited
Loading

depend on #11643

@6543
Copy link
Member Author

6543 commented May 27, 2020

CI will fail as long as there exist expected errors witch return 500 httpStatus!!!

so Update this branch until the point is where CI pass :)
StatusCode changes should happen in other pulls

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 27, 2020
This was referenced May 27, 2020
Merged
Merged
@6543
Copy link
Member Author

6543 commented May 27, 2020

next pull: #11644

@6543 6543 mentioned this pull request May 27, 2020
Merged
6543
6543 commented May 28, 2020
View reviewed changes
modules/context/api.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented May 29, 2020

it should pass if #11643 was merged

zeripath pushed a commit that referenced this pull request May 31, 2020
@6543
Handle expected errors in FileCreate & FileUpdate API (#11643)
b636cd6 
as title

needed for #11641
6543 added a commit to 6543-forks/gitea that referenced this pull request Jun 1, 2020
@6543
Handle expected errors in FileCreate & FileUpdate API (go-gitea#11643)
e01b95a 
as title

needed for go-gitea#11641
zeripath pushed a commit that referenced this pull request Jun 1, 2020
@6543
Handle expected errors in FileCreate & FileUpdate API (#11643) (#11718)
70739c3 
as title

needed for #11641
@guillep2k guillep2k modified the milestones: 1.12.0, 1.13.0 Jun 3, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 3, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 3, 2020
@6543
Copy link
Member Author

6543 commented Jun 3, 2020

ready to fly 🚀

@techknowlogick techknowlogick merged commit ce7510a into go-gitea:master Jun 3, 2020
@techknowlogick
Copy link
Member

@6543 please backport :)

@6543
Copy link
Member Author

6543 commented Jun 3, 2020

Feel free to do so, cant di it now

@6543 6543 deleted the API_InternalServerError_message-only-if-dev branch June 3, 2020 20:28
6543 added a commit to 6543-forks/gitea that referenced this pull request Jun 3, 2020
@6543
[API] on 500 error only show message if gitea in dev mode (go-gitea#1…
2d15151 
…1641)

* add API specific InternalServerError()

* return 500 error msg only if not Production mode

* rm unnessesary change
@6543 6543 mentioned this pull request Jun 3, 2020
Merged
@6543
Copy link
Member Author

6543 commented Jun 3, 2020

@techknowlogick had time to create it myselfe #11753

@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jun 4, 2020
techknowlogick pushed a commit that referenced this pull request Jun 4, 2020
@6543
[API] on 500 error only show message if gitea in dev mode (#11641) (#…
99058de 
…11753)

* add API specific InternalServerError()

* return 500 error msg only if not Production mode

* rm unnessesary change
@snyk-bot snyk-bot mentioned this pull request Jul 10, 2020
Open
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Handle expected errors in FileCreate & FileUpdate API (go-gitea#11643)
f29b101 
as title

needed for go-gitea#11641
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
[API] on 500 error only show message if gitea in dev mode (go-gitea#1…
6eb18a6 
…1641)

* add API specific InternalServerError()

* return 500 error msg only if not Production mode

* rm unnessesary change
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @techknowlogick @zeripath @guillep2k @GiteaBot