Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle expected errors in FileCreate & FileUpdate API #11643

Merged
merged 11 commits into from
May 31, 2020
Merged

Handle expected errors in FileCreate & FileUpdate API #11643

merged 11 commits into from
May 31, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented May 27, 2020

as title

needed for #11641

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 27, 2020
@zeripath zeripath added this to the 1.13.0 milestone May 27, 2020
@6543 6543 mentioned this pull request May 27, 2020
Merged
@zeripath zeripath changed the title [API] FileCreate & FileUpdate handle expected errors Handle expected errors in FileCreate & FileUpdate API May 27, 2020
@zeripath zeripath added the modifies/api This PR adds API routes or modifies them label May 27, 2020
@6543 6543 mentioned this pull request May 29, 2020
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 30, 2020
@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit b636cd6 into go-gitea:master May 31, 2020
@6543 6543 deleted the api_file-handle-errors branch June 1, 2020 02:16
6543 added a commit to 6543-forks/gitea that referenced this pull request Jun 1, 2020
@6543
Handle expected errors in FileCreate & FileUpdate API (go-gitea#11643)
e01b95a 
as title

needed for go-gitea#11641
@6543 6543 mentioned this pull request Jun 1, 2020
Merged
@6543
Copy link
Member Author

6543 commented Jun 1, 2020

Backpot #11718

@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jun 1, 2020
zeripath pushed a commit that referenced this pull request Jun 1, 2020
@6543
Handle expected errors in FileCreate & FileUpdate API (#11643) (#11718)
70739c3 
as title

needed for #11641
@snyk-bot snyk-bot mentioned this pull request Jul 10, 2020
Open
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Handle expected errors in FileCreate & FileUpdate API (go-gitea#11643)
f29b101 
as title

needed for go-gitea#11641
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @zeripath @lunny @techknowlogick @GiteaBot