Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile for ARM (RPi) #1404

Closed
wants to merge 2 commits into from
Closed

Dockerfile for ARM (RPi) #1404

wants to merge 2 commits into from

Conversation

ulm0
Copy link

@ulm0 ulm0 commented Mar 29, 2017

Dockerfile for ARM

I had some problems when using the Dockerfile.rpi file to build the image for my RPi3 as mentioned in #531 so i made some modifications to the current Dockerfile, such as downloading the binary from the official folder provided by gitea in their web site, and creating the folder /app/gitea within the image.

@appleboy appleboy added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Mar 29, 2017
@lunny lunny added this to the 1.2.0 milestone Mar 29, 2017
@lunny lunny added type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Mar 29, 2017
@Morlinest
Copy link
Member

Morlinest commented Mar 29, 2017

Hi, I do not know how are you doing images guys, but personaly i do not like the idea of downloading the binary (and you still have to copy docker folder). You can not use your own build, test features, can not be use with CI and autobuild etc. Now its posible to download repo and build everything from it, with this new solution you will have to download repo and hope your version of files (docker folder and also Dockerfile) are compatible with downloaded binary (example: you want older version of program but binary is latest or you want program with the newest features but binary is old).

Sorry for english, not my native language.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2017
@ulm0
Copy link
Author

ulm0 commented Mar 29, 2017

@Morlinest, you're right, this is not the best approach. Because you can't just use the Dockerfile alone and build it. This Dockerfile.rpi file is based on the current one which depends on the repo by copying the docker folder into the image, i tried to use it to build the images but faced some problems as mentioned in #531 so i came up with this approach which i built using an ARM runner i have in GitLab, of course you can build the binary on the go when building the image (instead of downloading it, though you can compare checksums and so on), but it ends being a really heavy image and imho the image should be as lightweight as possible. This is just my point of view since i'm far from being a docker expert. But i'll come up with a better approach as soon as i can.

@tboerger
Copy link
Member

👎 for these changes. Just add one more make task like docker-rpi.

@tboerger
Copy link
Member

That being said the Dockerfile is structured like that on purpose.

@ulm0 ulm0 closed this Apr 18, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants