Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KanBan: be able to set default board #14147

Merged
merged 34 commits into from
Jan 15, 2021
Merged

KanBan: be able to set default board #14147

merged 34 commits into from
Jan 15, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 25, 2020

as title

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 25, 2020
6543
6543 commented Dec 25, 2020
View reviewed changes
routers/repo/projects.go Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Dec 26, 2020
View reviewed changes
routers/repo/projects.go Outdated Show resolved Hide resolved
@6543 6543 marked this pull request as ready for review December 27, 2020 01:04
@6543 6543 added the type/enhancement An improvement of existing functionality label Dec 27, 2020
@6543 6543 added this to the 1.14.0 milestone Dec 27, 2020
lunny
lunny reviewed Dec 27, 2020
View reviewed changes
models/project_board.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Dec 27, 2020 •
edited
Loading

Codecov Report

Merging #14147 (123b8c6) into master (f76c300) will decrease coverage by 0.00%.
The diff coverage is 39.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14147      +/-   ##
==========================================
- Coverage   41.85%   41.84%   -0.01%     
==========================================
  Files         744      744              
  Lines       79638    79680      +42     
==========================================
+ Hits        33335    33346      +11     
- Misses      40817    40835      +18     
- Partials     5486     5499      +13
Impacted Files Coverage Δ
routers/repo/projects.go 13.58% <20.00%> (+0.16%) ⬆️
models/project_board.go 41.79% <48.93%> (-4.82%) ⬇️
routers/routes/macaron.go 93.23% <100.00%> (+<0.01%) ⬆️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/git/repo_commit_nogogit.go 65.00% <0.00%> (+1.66%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
modules/indexer/stats/db.go 68.00% <0.00%> (+12.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76c300...123b8c6. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2020
@6543

This comment has been minimized.

Sign in to view
@6543
Copy link
Member Author

6543 commented Jan 3, 2021

@silverwind JS code changed

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2021
@lafriks lafriks merged commit 3091600 into go-gitea:master Jan 15, 2021
@lafriks lafriks deleted the default-board branch January 15, 2021 20:29
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 19, 2021
@a1012112796
Merge branch 'master' into imap
560f48a 
* master: (27 commits)
  Use path not filepath in routers/editor (go-gitea#14390)
  Display error if twofaSecret cannot be retrieved (go-gitea#14372)
  Check if label template exist first (go-gitea#14384)
  Allow passcode invalid error to appear (go-gitea#14371)
  exclude authored PRs from Review Requested filter (go-gitea#14368)
  Upgrade blevesearch dependency to v2.0.1 (go-gitea#14346)
  Implement ghost comment mitigation (go-gitea#14349)
  Add edit, delete and reaction support to code review comments on issue page (go-gitea#14339)
  Add review requested filter on pull request overview (go-gitea#13701)
  escape branch names in compare url (go-gitea#14364)
  label and milestone webhooks on issue/pull creation (go-gitea#14363)
  Fix middlewares sequences (go-gitea#14354)
  Sort issue search results by revelance (go-gitea#14353)
  KanBan: be able to set default board (go-gitea#14147)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@silverwind silverwind silverwind left review comments

@lunny lunny lunny left review comments

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@6543 @codecov-io @lunny @silverwind @lafriks @zeripath @GiteaBot