Display error if twofaSecret cannot be retrieved #14372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
approved these changes
Jan 18, 2021
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Jan 18, 2021
GiteaBot
added
lgtm/done
|
I'm confused as to why this is happening in the first place - perhaps there's some race? |
|
Ah I wonder if this is a double click/double post scenario? |
Codecov Report
@@ Coverage Diff @@
## master #14372 +/- ##
==========================================
+ Coverage 41.84% 41.85% +0.01%
==========================================
Files 744 744
Lines 79741 79746 +5
==========================================
+ Hits 33364 33379 +15
+ Misses 40863 40858 -5
+ Partials 5514 5509 -5
Continue to review full report at Codecov.
|
@zeripath As mentioned over at #14144 (comment), I believe it's the Malwarebytes Firefox addon that's removing the value / messing with it so it's not technically a gitea issue, but at least with this PR we nicely guard against the 500. |
ashmckenzie
deleted the
ashmckenzie/catch-error-where-2fa-secret-not-available
branch
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Jan 19, 2021
* master: (27 commits) Use path not filepath in routers/editor (go-gitea#14390) Display error if twofaSecret cannot be retrieved (go-gitea#14372) Check if label template exist first (go-gitea#14384) Allow passcode invalid error to appear (go-gitea#14371) exclude authored PRs from Review Requested filter (go-gitea#14368) Upgrade blevesearch dependency to v2.0.1 (go-gitea#14346) Implement ghost comment mitigation (go-gitea#14349) Add edit, delete and reaction support to code review comments on issue page (go-gitea#14339) Add review requested filter on pull request overview (go-gitea#13701) escape branch names in compare url (go-gitea#14364) label and milestone webhooks on issue/pull creation (go-gitea#14363) Fix middlewares sequences (go-gitea#14354) Sort issue search results by revelance (go-gitea#14353) KanBan: be able to set default board (go-gitea#14147) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue discussed at #14144 where the
twofaSecretcannot be retrieved from the session. Here we capture this scenario, display the error messageFailed to get secret.and handle it gracefully instead of returning a 500: