Prevent showing webauthn error for every time visiting /user/settings/security
#18385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should be hiding the register button if detect-webauthn is not detected. |
GiteaBot
added
the
lgtm/need 2
It would be a bigger change, we should find some where to show the error message. Otherwise the users wouldn't know what happened and they would come to ask why I can not use webauthn ..... This PR just works and it seems fine to show the Security Key UI to tell users here we have a nice feature. And I am open, if there is a better PR, feel free to use it to replace this one. |
This comment has been minimized.
This comment has been minimized.
zeripath
approved these changes
Jan 24, 2022
GiteaBot
added
lgtm/need 1
Gusted
approved these changes
Jan 24, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 25, 2022
* giteaoffical/main: Place inline diff comment dialogs on split diff in 4th and 8th columns (go-gitea#18403) API: Return primary language and repository language stats API URL (go-gitea#18396) Update to work with latest VS Code go debugger (go-gitea#18397) Fix restore without topic failure (go-gitea#18387) [skip ci] Updated translations via Crowdin Make WrappedQueues and PersistableChannelUniqueQueues Pausable (go-gitea#18393) Fix commit's time (go-gitea#18375) Prevent showing webauthn error for every time visiting `/user/settings/security` (go-gitea#18385)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite annoying that the webauthn error is popped up every time when visiting
/user/settings/security.After this fix, the error is only shown after the user clicks the register (add security key) button.